mbox series

[bug#62284,00/70] gnu: Add mautrix-whatsapp.

Message ID cover.1679268195.git.contact@conses.eu
Headers show
Series gnu: Add mautrix-whatsapp. | expand

Message

Miguel Ángel Moreno March 19, 2023, 11:25 p.m. UTC 
Hi,

This patch series adds a package for
<https://github.com/mautrix/whatsapp>, a Matrix-WhatsApp puppetting
bridge.  I've tested it's working with the latest version of Synapse in
my personal homeserver for the past few months without any issues.

The only thing worth noting from this patch series is that I had to
remove some symlinks to Go libraries in the mautrix-whatsapp package
phases and instead copy the real library directories, otherwise I would
encounter issues with go:embed invocations complaining there were no
files found.  I'm not knowledgeable in Go, but from the documentation
<https://pkg.go.dev/embed> and other information I found online, namely
this issue <https://github.com/golang/go/issues/44507>, embeds don't
support symlinks, hence the workaround.

conses (70):
  gnu: Add go-github-com-tidwall-sjson.
  gnu: Add go-github-com-tidwall-gjson.
  gnu: Add go-github-com-tidwall-match.
  gnu: Add go-github-com-tidwall-pretty.
  gnu: go-google-golang-org-protobuf: Update to 1.30.0.
  gnu: Add go-google-golang-org-protobuf-package.
  gnu: Add go-google-golang-org-protobuf-proto.
  gnu: Add go-google-golang-org-protobuf-reflect-protoreflect.
  gnu: Add go-google-golang-org-protobuf-reflect-protoregistry.
  gnu: Add go-google-golang-org-protobuf-encoding-protowire.
  gnu: Add go-google-golang-org-protobuf-encoding-prototext.
  gnu: Add go-google-golang-org-protobuf-internal-encoding-text.
  gnu: Add go-google-golang-org-protobuf-internal-encoding-messageset.
  gnu: Add go-google-golang-org-protobuf-internal-encoding-defval.
  gnu: Add go-google-golang-org-protobuf-internal-encoding-tag.
  gnu: Add go-google-golang-org-protobuf-internal-errors.
  gnu: Add go-google-golang-org-protobuf-internal-set.
  gnu: Add go-google-golang-org-protobuf-internal-descfmt.
  gnu: Add go-google-golang-org-protobuf-internal-descopts.
  gnu: Add go-google-golang-org-protobuf-internal-flags.
  gnu: Add go-google-golang-org-protobuf-internal-genid.
  gnu: Add go-google-golang-org-protobuf-internal-order.
  gnu: Add go-google-golang-org-protobuf-internal-pragma.
  gnu: Add go-google-golang-org-protobuf-internal-strs.
  gnu: Add go-google-golang-org-protobuf-internal-detrand.
  gnu: Add go-google-golang-org-protobuf-internal-filedesc.
  gnu: Add go-google-golang-org-protobuf-internal-filetype.
  gnu: Add go-google-golang-org-protobuf-internal-impl.
  gnu: Add go-google-golang-org-protobuf-internal-version.
  gnu: Add go-google-golang-org-protobuf-runtime-protoiface.
  gnu: Add go-google-golang-org-protobuf-runtime-protoimpl.
  gnu: Add go-github-com-skip2-go-qrcode.
  gnu: Add go-maunium-net-go-mauflag.
  gnu: Add go-maunium-net-go-maulogger.
  gnu: Add go-mau-fi-libsignal.
  gnu: Add go-mau-fi-libsignal-package.
  gnu: Add go-mau-fi-libsignal-ecc.
  gnu: Add go-mau-fi-libsignal-groups.
  gnu: Add go-mau-fi-libsignal-cipher.
  gnu: Add go-mau-fi-libsignal-kdf.
  gnu: Add go-mau-fi-libsignal-keys-identity.
  gnu: Add go-mau-fi-libsignal-keys-prekey.
  gnu: Add go-mau-fi-libsignal-keys-chain.
  gnu: Add go-mau-fi-libsignal-keys-message.
  gnu: Add go-mau-fi-libsignal-keys-root.
  gnu: Add go-mau-fi-libsignal-keys-session.
  gnu: Add go-mau-fi-libsignal-logger.
  gnu: Add go-mau-fi-libsignal-ratchet.
  gnu: Add go-mau-fi-libsignal-serialize.
  gnu: Add go-mau-fi-libsignal-protocol.
  gnu: Add go-mau-fi-libsignal-session.
  gnu: Add go-mau-fi-libsignal-signalerror.
  gnu: Add go-mau-fi-libsignal-state-record.
  gnu: Add go-mau-fi-libsignal-state-store.
  gnu: Add go-mau-fi-libsignal-util-bytehelper.
  gnu: Add go-mau-fi-libsignal-util-keyhelper.
  gnu: Add go-mau-fi-libsignal-util-optional.
  gnu: Add go-mau-fi-libsignal-util-errorhelper.
  gnu: Add go-mau-fi-libsignal-util-medium.
  gnu: Add go-mau-fi-whatsmeow.
  gnu: Add go-github-com-rs-xid.
  gnu: go-github-com-mattn-go-isatty: Update to 0.1.13.
  gnu: Add go-github-com-coreos-go-systemd.
  gnu: Add go-github-com-coreos-go-systemd-journal.
  gnu: Add go-github-com-rs-zerolog.
  gnu: Add go-mau-fi-zeroconfig.
  gnu: Add go-maunium-net-go-mautrix.
  gnu: go-github-com-mattn-go-sqlite3: Update to 1.14.16.
  gnu: Add go-github-com-chai2010-webp.
  gnu: Add mautrix-whatsapp.

 gnu/packages/golang.scm | 635 +++++++++++++++++++++++++++++++++++++++-
 gnu/packages/matrix.scm | 121 ++++++++
 2 files changed, 748 insertions(+), 8 deletions(-)

Comments

Sharlatan Hellseher Feb. 22, 2024, 4:28 p.m. UTC | #1 
Hi conses and Miguel,

Thank you for the patches!

I've started the review process on them, and QA testing revealed that
some of the patches did not pass checks yet. Additionally, I understand
that the series is quite lengthy, making it challenging to keep it in
sync with the changes in the current master branch.

I would also like to mention that there are dedicated submodules for
Golang packages available that aim to assist in maintaining the
monolithic and diverse Golang ecosystem within Guix.

If possible, could you consider placing the packages in any appropriate
submodule? When you review the golang-*.scm files, you'll notice an
annotation header indicating the packages it expects to contain, and
it's preferable to avoid adding new packages in golang.scm.

Thanks,
Oleg