diff mbox series

[bug#68556,gnome-team,24/25] gnu: gnome-shell-extension-vertical-overview: Update style.

Message ID feb764a60d9e65261a63e8d35fff913435fffa9a.1705532622.git.vivien@planete-kraus.eu
State New
Headers show
Series Update the GNOME Shell extensions | expand

Commit Message

Vivien Kraus Jan. 17, 2024, 10:48 p.m. UTC
* gnu/packages/gnome-xyz.scm (gnome-shell-extension-vertical-overview)
[arguments]: Convert to list of G-Expressions.

Change-Id: I830854d7c2ce262906331e5aef59f6dd7af28c98
---
 gnu/packages/gnome-xyz.scm | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

Comments

Liliana Marie Prikler Jan. 18, 2024, 5:24 a.m. UTC | #1
Am Mittwoch, dem 17.01.2024 um 23:48 +0100 schrieb Vivien Kraus:
> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-vertical-
> overview)
> [arguments]: Convert to list of G-Expressions.
> 
> Change-Id: I830854d7c2ce262906331e5aef59f6dd7af28c98
Given that it's removed in the next commit, this is just noise. 
Probably same for the other removed extensions.

Do we have alternatives for these or is it just "extension no work"?
Vivien Kraus Jan. 18, 2024, 11:38 a.m. UTC | #2
Le jeudi 18 janvier 2024 à 06:24 +0100, Liliana Marie Prikler a écrit :
> Am Mittwoch, dem 17.01.2024 um 23:48 +0100 schrieb Vivien Kraus:
> > * gnu/packages/gnome-xyz.scm (gnome-shell-extension-vertical-
> > overview)
> > [arguments]: Convert to list of G-Expressions.
> > 
> > Change-Id: I830854d7c2ce262906331e5aef59f6dd7af28c98
> Given that it's removed in the next commit, this is just noise. 
> Probably same for the other removed extensions.

I figured that it would be easier to revert and update if and when the
extension  is ported to a newer GNOME Shell. I agree though, if someone
wants to add the extension again, they probably won’t read the git log,
so it’s not very helpful.

> Do we have alternatives for these or is it just "extension no work"?
I don’t know much.

From what I understand, hide-app-icon is not replaced, but now the
application icons in the shell are symbolic and tiny, so maybe it’s not
needed anymore.

On the repository, people are talking about forking jiggle, but I don’t
know of any alternative.

NoAnnoyance has a fork that claims support for 44, maybe we should
package that, what do you think?
https://extensions.gnome.org/extension/6109/noannoyance-fork/

Sound output device chooser is obsolete because now with the shell you
can directly choose the audio device.

The panel already shows system tray icons, so Topicons Redux is not
needed anymore.

There is a candidate replacement for Transparent Window,
https://extensions.gnome.org/extension/1454/transparent-window/ but it
does not support GNOME 44 either.

Maybe V-Shell
https://extensions.gnome.org/extension/5177/vertical-workspaces/ can
replace Vertical overview?

I’m not a fan of removing packages like that, because guix upgrade will
quickly complain about profile collisions. But I would like to hear the
users about these candidate replacements for NoAnnoyance v2
(NoAnnoyance Fork) and Vertical overview (V-Shell) first, and the users
on the extensions forum do not seem to talk about these replacements.

What do you think?

Best regards,

Vivien
Liliana Marie Prikler Jan. 18, 2024, 7:53 p.m. UTC | #3
Am Donnerstag, dem 18.01.2024 um 12:38 +0100 schrieb Vivien Kraus:
> Le jeudi 18 janvier 2024 à 06:24 +0100, Liliana Marie Prikler a
> écrit :
> > Am Mittwoch, dem 17.01.2024 um 23:48 +0100 schrieb Vivien Kraus:
> > > * gnu/packages/gnome-xyz.scm (gnome-shell-extension-vertical-
> > > overview)
> > > [arguments]: Convert to list of G-Expressions.
> > > 
> > > Change-Id: I830854d7c2ce262906331e5aef59f6dd7af28c98
> > Given that it's removed in the next commit, this is just noise. 
> > Probably same for the other removed extensions.
> 
> I figured that it would be easier to revert and update if and when
> the extension  is ported to a newer GNOME Shell. I agree though, if
> someone wants to add the extension again, they probably won’t read
> the git log, so it’s not very helpful.
Even then, people can just run `guix style' from that hypothetical
commit, and it might even have more features then.

> > Do we have alternatives for these or is it just "extension no
> > work"?
> I don’t know much.
> 
> From what I understand, hide-app-icon is not replaced, but now the
> application icons in the shell are symbolic and tiny, so maybe it’s
> not needed anymore.
As long as they're not gone, there's a need to replace them.  However,
another extension like just-perfection might do this.

> On the repository, people are talking about forking jiggle, but I
> don’t know of any alternative.
Let's keep looking, then.

> NoAnnoyance has a fork that claims support for 44, maybe we should
> package that, what do you think?
> https://extensions.gnome.org/extension/6109/noannoyance-fork/
Packaging forks is fair game.  We can revert to the original whenever.
Just leave a comment that it's a fork and why we're using it.

> Sound output device chooser is obsolete because now with the shell
> you can directly choose the audio device.
Good news for users, but awkward in terms of packaging.  I don't thing
(deprecated-package gnome …) will work as intended. 

> The panel already shows system tray icons, so Topicons Redux is not
> needed anymore.
> 
> There is a candidate replacement for Transparent Window,
> https://extensions.gnome.org/extension/1454/transparent-window/ but
> it does not support GNOME 44 either.
Bummer.

> Maybe V-Shell
> https://extensions.gnome.org/extension/5177/vertical-workspaces/ can
> replace Vertical overview?


> I’m not a fan of removing packages like that, because guix upgrade
> will quickly complain about profile collisions.  
Profile collisions come from propagated packages, not deprecated
packages.

> But I would like to hear the users about these candidate replacements
> for NoAnnoyance v2 (NoAnnoyance Fork) and Vertical overview (V-Shell)
> first, and the users on the extensions forum do not seem to talk
> about these replacements.
> 
> What do you think?
I don't think we'll get much feedback from elsewhere, but with gnome-
team building substitutes again, I can at least try some out.

Cheers
diff mbox series

Patch

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 4eddecf472..0bc7fe9b73 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -1045,18 +1045,19 @@  (define-public gnome-shell-extension-vertical-overview
         '(begin (delete-file "schemas/gschemas.compiled")))))
     (build-system copy-build-system)
     (arguments
-     `(#:install-plan
-       '(("." ,(string-append
-                "share/gnome-shell/extensions/"
-                "vertical-overview@RensAlthuis.github.com")
-          #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$"
-                            "\\.xml$" "\\.compiled$")))
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'install 'compile-schemas
-           (lambda _
-             (with-directory-excursion "schemas"
-               (invoke "glib-compile-schemas" ".")))))))
+     (list
+      #:install-plan
+      #~'(("." #$(string-append
+                  "share/gnome-shell/extensions/"
+                  "vertical-overview@RensAlthuis.github.com")
+           #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$"
+                             "\\.xml$" "\\.compiled$")))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'install 'compile-schemas
+            (lambda _
+              (with-directory-excursion "schemas"
+                (invoke "glib-compile-schemas" ".")))))))
     (native-inputs
      (list `(,glib "bin")))  ; for glib-compile-resources
     (home-page "https://github.com/RensAlthuis/vertical-overview")