Message ID | b9816b12ede7922cc392788e9d8d29758a7ff389.1689690897.git.janneke@gnu.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id AD72927BBE9; Tue, 18 Jul 2023 15:43:19 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4750127BBE2 for <patchwork@mira.cbaines.net>; Tue, 18 Jul 2023 15:43:18 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1qLlu1-0007qq-Hy; Tue, 18 Jul 2023 10:42:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qLlty-0007jt-TD for guix-patches@gnu.org; Tue, 18 Jul 2023 10:42:10 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qLlty-0000wW-Km for guix-patches@gnu.org; Tue, 18 Jul 2023 10:42:10 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qLlty-0006fD-FX; Tue, 18 Jul 2023 10:42:10 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64711] [PATCH 26/43] gnu: cairo: Support building for the Hurd. Resent-From: Janneke Nieuwenhuizen <janneke@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: liliana.prikler@gmail.com, maxim.cournoyer@gmail.com, rg@raghavgururajan.name, guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 14:42:10 +0000 Resent-Message-ID: <handler.64711.B64711.168969131225427@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64711@debbugs.gnu.org Cc: Liliana Marie Prikler <liliana.prikler@gmail.com>, Maxim Cournoyer <maxim.cournoyer@gmail.com>, Raghav Gururajan <rg@raghavgururajan.name> X-Debbugs-Original-Xcc: Liliana Marie Prikler <liliana.prikler@gmail.com>, Maxim Cournoyer <maxim.cournoyer@gmail.com>, Raghav Gururajan <rg@raghavgururajan.name> Received: via spool by 64711-submit@debbugs.gnu.org id=B64711.168969131225427 (code B ref 64711); Tue, 18 Jul 2023 14:42:10 +0000 Received: (at 64711) by debbugs.gnu.org; 18 Jul 2023 14:41:52 +0000 Received: from localhost ([127.0.0.1]:53816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1qLltg-0006c3-4g for submit@debbugs.gnu.org; Tue, 18 Jul 2023 10:41:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <janneke@gnu.org>) id 1qLlta-0006b5-CV for 64711@debbugs.gnu.org; Tue, 18 Jul 2023 10:41:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <janneke@gnu.org>) id 1qLltV-0000lo-5Q; Tue, 18 Jul 2023 10:41:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=8w2E8wlxCE08Q6KPeOVzxChQEzOq/9cvmcLzPrJ8oNg=; b=CqxcqOTCjhNItj16d4kC miEa+qljdLVkL2IppkvGZNIuRXzc9CznDIIFyPk4FytngxyCayFSqyKPgqcsYLT3z7Aq12KcFs0vY nrLtz256705nb0f/h4J5ygDW9nHDB8ZbQT+RCmpT/UnKhhpS4DshyPQ9xgXr+3FBVykbgkC3nD/Yt 5RGWPhV62J4rsWdzDQa+mp6LCiAdCyZlnHp0Tpylrj97Pk5b+P/Onzf0AS3qCl77XRSm6oyp1A5uO YgC8XAnFCzpWoKukVq4rSJwj+38umV5ABVSQPlhAylO8dkRN+wV1Bb1bJN/a5n1HTxhXagekrv276 TpJPRcynMN9wXQ==; Received: from 2a02-a462-da03-1-aeb0-2f5e-e96a-dccb.fixed6.kpn.net ([2a02:a462:da03:1:aeb0:2f5e:e96a:dccb] helo=drakenpad.fritz.box) by fencepost.gnu.org with esmtpa (Exim 4.90_1) (envelope-from <janneke@gnu.org>) id 1qLltS-0004hp-D7; Tue, 18 Jul 2023 10:41:40 -0400 From: Janneke Nieuwenhuizen <janneke@gnu.org> Date: Tue, 18 Jul 2023 16:40:19 +0200 Message-Id: <b9816b12ede7922cc392788e9d8d29758a7ff389.1689690897.git.janneke@gnu.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <cover.1689690897.git.janneke@gnu.org> References: <cover.1689690897.git.janneke@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
Fix builds and skip failing tests for the Hurd.
|
|
Commit Message
Janneke Nieuwenhuizen
July 18, 2023, 2:40 p.m. UTC
Gobject-introspection and libdrm does not build for the Hurd. Poppler depends on nss, which does not build for the Hurd. * gnu/packages/gtk.scm (cairo)[native-inputs]: When building for the Hurd, do not include gobject-introspection. [inputs]: Likewise, do not include libdrm, poppler. --- gnu/packages/gtk.scm | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
Comments
Am Dienstag, dem 18.07.2023 um 16:40 +0200 schrieb Janneke Nieuwenhuizen: > Gobject-introspection and libdrm does not build for the Hurd. > Poppler depends > on nss, which does not build for the Hurd. > > * gnu/packages/gtk.scm (cairo)[native-inputs]: When building for the > Hurd, do > not include gobject-introspection. > [inputs]: Likewise, do not include libdrm, poppler. Could we provide a minimal gobject-introspection that builds for the hurd? Cheers
Liliana Marie Prikler writes: > Am Dienstag, dem 18.07.2023 um 16:40 +0200 schrieb Janneke > Nieuwenhuizen: >> Gobject-introspection and libdrm does not build for the Hurd. >> Poppler depends >> on nss, which does not build for the Hurd. >> >> * gnu/packages/gtk.scm (cairo)[native-inputs]: When building for the >> Hurd, do >> not include gobject-introspection. >> [inputs]: Likewise, do not include libdrm, poppler. > Could we provide a minimal gobject-introspection that builds for the > hurd? That would be nice. Note that Debian doesn't support gobject-introspection on the Hurd, unless I'm mistaken. Greetings, Janneke
Hi, Janneke Nieuwenhuizen <janneke@gnu.org> writes: > Liliana Marie Prikler writes: > >> Am Dienstag, dem 18.07.2023 um 16:40 +0200 schrieb Janneke >> Nieuwenhuizen: >>> Gobject-introspection and libdrm does not build for the Hurd. >>> Poppler depends >>> on nss, which does not build for the Hurd. >>> >>> * gnu/packages/gtk.scm (cairo)[native-inputs]: When building for the >>> Hurd, do >>> not include gobject-introspection. >>> [inputs]: Likewise, do not include libdrm, poppler. > >> Could we provide a minimal gobject-introspection that builds for the >> hurd? > > That would be nice. Note that Debian doesn't support > gobject-introspection on the Hurd, unless I'm mistaken. I wonder what prevents gobject-introspection from running on the Hurd?
Maxim Cournoyer writes: Hi! > Janneke Nieuwenhuizen <janneke@gnu.org> writes: > >> Liliana Marie Prikler writes: >> >>> Am Dienstag, dem 18.07.2023 um 16:40 +0200 schrieb Janneke >>> Nieuwenhuizen: >>>> Gobject-introspection and libdrm does not build for the Hurd. >>>> Poppler depends >>>> on nss, which does not build for the Hurd. >>>> >>>> * gnu/packages/gtk.scm (cairo)[native-inputs]: When building for the >>>> Hurd, do >>>> not include gobject-introspection. >>>> [inputs]: Likewise, do not include libdrm, poppler. >> >>> Could we provide a minimal gobject-introspection that builds for the >>> hurd? >> >> That would be nice. Note that Debian doesn't support >> gobject-introspection on the Hurd, unless I'm mistaken. > > I wonder what prevents gobject-introspection from running on the Hurd? Find build log attached. Janneke
Hi Janneke, Janneke Nieuwenhuizen <janneke@gnu.org> writes: > Maxim Cournoyer writes: > > Hi! > >> Janneke Nieuwenhuizen <janneke@gnu.org> writes: >> >>> Liliana Marie Prikler writes: >>> >>>> Am Dienstag, dem 18.07.2023 um 16:40 +0200 schrieb Janneke >>>> Nieuwenhuizen: >>>>> Gobject-introspection and libdrm does not build for the Hurd. >>>>> Poppler depends >>>>> on nss, which does not build for the Hurd. >>>>> >>>>> * gnu/packages/gtk.scm (cairo)[native-inputs]: When building for the >>>>> Hurd, do >>>>> not include gobject-introspection. >>>>> [inputs]: Likewise, do not include libdrm, poppler. >>> >>>> Could we provide a minimal gobject-introspection that builds for the >>>> hurd? >>> >>> That would be nice. Note that Debian doesn't support >>> gobject-introspection on the Hurd, unless I'm mistaken. >> >> I wonder what prevents gobject-introspection from running on the Hurd? > > Find build log attached. Interesting. Debian carries no Hurd patch for it [0], and upstream doesn't seem to know about this issue [1]. [0] http://deb.debian.org/debian/pool/main/g/gobject-introspection/gobject-introspection_1.76.1-1.debian.tar.xz [1] https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/?sort=created_date&state=opened&search=getauxval&first_page_size=20
Maxim Cournoyer writes: Hi Maxim, > Janneke Nieuwenhuizen <janneke@gnu.org> writes: > >> Maxim Cournoyer writes: >> >> Hi! >> >>> Janneke Nieuwenhuizen <janneke@gnu.org> writes: >>> >>>> Liliana Marie Prikler writes: >>>> >>>>> Am Dienstag, dem 18.07.2023 um 16:40 +0200 schrieb Janneke >>>>> Nieuwenhuizen: >>>>>> Gobject-introspection and libdrm does not build for the Hurd. >>>>>> Poppler depends >>>>>> on nss, which does not build for the Hurd. >>>>>> >>>>>> * gnu/packages/gtk.scm (cairo)[native-inputs]: When building for the >>>>>> Hurd, do >>>>>> not include gobject-introspection. >>>>>> [inputs]: Likewise, do not include libdrm, poppler. >>>> >>>>> Could we provide a minimal gobject-introspection that builds for the >>>>> hurd? >>>> >>>> That would be nice. Note that Debian doesn't support >>>> gobject-introspection on the Hurd, unless I'm mistaken. I was mistaken; I've checked it again and gobject-introspection is installable for the Hurd. --8<---------------cut here---------------start------------->8--- ii gobject-introspection 1.74.0-3 hurd-i386 Generate interface introspection data for GObject libraries --8<---------------cut here---------------end--------------->8--- >>> I wonder what prevents gobject-introspection from running on the Hurd? >> >> Find build log attached. > > Interesting. Debian carries no Hurd patch for it [0], and upstream > doesn't seem to know about this issue [1]. Hmm? Interesting indeed... > [0] http://deb.debian.org/debian/pool/main/g/gobject-introspection/gobject-introspection_1.76.1-1.debian.tar.xz > [1] https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/?sort=created_date&state=opened&search=getauxval&first_page_size=20
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index 9621357b99..eb69a88221 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -35,6 +35,7 @@ ;;; Copyright © 2022 Petr Hodina <phodina@protonmail.com> ;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr> ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> +;;; Copyright © 2023 Janneke Nieuwenhuizen <janneke@gnu.org> ;;; ;;; This file is part of GNU Guix. ;;; @@ -194,15 +195,21 @@ (define-public cairo (assoc-ref %outputs "doc") "/share/gtk-doc/html")))) (native-inputs - `(("gobject-introspection" ,gobject-introspection) + `(,@(if (target-hurd?) + '() + `(("gobject-introspection" ,gobject-introspection))) ("pkg-config" ,pkg-config) ("python" ,python-wrapper))) (inputs `(("bash-minimal" ,bash-minimal) ;for glib-or-gtk-wrap - ("drm" ,libdrm) + ,@(if (target-hurd?) + '() + `(("drm" ,libdrm))) ("ghostscript" ,ghostscript) ("libspectre" ,libspectre) - ("poppler" ,poppler))) + ,@(if (target-hurd?) + '() + `(("poppler" ,poppler))))) (propagated-inputs `( ;; ("cogl" ,cogl) ;; ("directfb" ,directfb)