| Message ID | a4b0cd40c3a2f8adc9d096b285ab81e5abfa4b1c.1696881354.git.mirai@makinata.eu |
|---|---|
| State | New |
| Headers | show |
| Series | Docbook & XML/SGML improvements | expand |
Am Montag, dem 09.10.2023 um 21:06 +0100 schrieb Bruno Victal: > Observations: > 1. No longer required for XML_CATALOG_FILES. This is the correct observation. Stop there if there's nothing else to say :) Explain why it's no longer needed otherwise (I don't see the full series, so it may be obvious from context). > These are already adequately set within the used dependencies > 2. It's not required for gnome-session but by libxkbcommon. > libxkbcommon was fixed to convey this by use of a symlink. Propagation of inputs isn't always easy. Thus, if libxkbcommon were to need a tool from libxml2 at configuration or compile time, it'd need to remain a native input. I take it that this is not the case, just hinting that the tangent on which you are going might not be right for a commit explanation. > 2.1. Shouldn't count as a native-input but as a regular input. > … since this is a dependency for xkbregistry (from > libxkbcommon). Red herring. > * gnu/packages/gnome.scm (gnome-session)[native-inputs]: Remove > libxml2. > --- > gnu/packages/gnome.scm | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 4e61497ca8..c7e655bc35 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -7628,7 +7628,6 @@ (define-public gnome-session > docbook-xsl > `(,glib "bin") ; for glib-compile-schemas, > etc. > intltool > - libxml2 ;for 'XML_CATALOG_FILES' > libxslt > pkg-config > xmlto)) Cheers
Hi Liliana, Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Montag, dem 09.10.2023 um 21:06 +0100 schrieb Bruno Victal: >> Observations: >> 1. No longer required for XML_CATALOG_FILES. > This is the correct observation. Stop there if there's nothing else to > say :) Explain why it's no longer needed otherwise (I don't see the > full series, so it may be obvious from context). >> These are already adequately set within the used dependencies >> 2. It's not required for gnome-session but by libxkbcommon. >> libxkbcommon was fixed to convey this by use of a symlink. > Propagation of inputs isn't always easy. Thus, if libxkbcommon were to > need a tool from libxml2 at configuration or compile time, it'd need to > remain a native input. I take it that this is not the case, just > hinting that the tangent on which you are going might not be right for > a commit explanation. >> 2.1. Shouldn't count as a native-input but as a regular input. >> … since this is a dependency for xkbregistry (from >> libxkbcommon). > Red herring. I tried addressing your comments, but since I'm not the author and I had no reasons to doubt Bruno's observations, I've left them as-is. I hope that's fine given it's only about the commit message.
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 4e61497ca8..c7e655bc35 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -7628,7 +7628,6 @@ (define-public gnome-session docbook-xsl `(,glib "bin") ; for glib-compile-schemas, etc. intltool - libxml2 ;for 'XML_CATALOG_FILES' libxslt pkg-config xmlto))
Observations: 1. No longer required for XML_CATALOG_FILES. These are already adequately set within the used dependencies 2. It's not required for gnome-session but by libxkbcommon. libxkbcommon was fixed to convey this by use of a symlink. 2.1. Shouldn't count as a native-input but as a regular input. … since this is a dependency for xkbregistry (from libxkbcommon). * gnu/packages/gnome.scm (gnome-session)[native-inputs]: Remove libxml2. --- gnu/packages/gnome.scm | 1 - 1 file changed, 1 deletion(-)