mbox series

[bug#66180,00/19] Sort packages in node-xyz.scm

Message ID cover.1695559497.git.ngraves@ngraves.fr
Headers show
Series Sort packages in node-xyz.scm | expand

Message

Nicolas Graves Sept. 24, 2023, 12:47 p.m. UTC
This patch series roughly sorts the whole node-xyz.scm file, and adds
a reminder header to add packages in the alphabetical order.

Nicolas Graves (19):
  gnu: node-bindings: Move package in alphabetical order.
  gnu: node-util-deprecate: Move package in alphabetical order.
  gnu: node-once: Move package in alphabetical order.
  gnu: node-ieee754: Move package in alphabetical order.
  gnu: node-inherits: Move package in alphabetical order.
  gnu: node-safe-buffer: Move package in alphabetical order.
  gnu: node-string-decoder: Move package in alphabetical order.
  gnu: node-readable-stream: Move package in alphabetical order.
  gnu: node-irc and node-irc-colors: Move in alphabetical order.
  gnu: node-nan: Move package in alphabetical order.
  gnu: node-addon-api: Move package in alphabetical order.
  gnu: node-sqlite3: Move package in alphabetical order.
  gnu: node-file-uri-to-path: Move package in alphabetical order.
  gnu: node-segfault-handler: Move package in alphabetical order.
  gnu: node-ms: Move package in alphabetical order.
  gnu: node-debug: Move package in alphabetical order.
  gnu: node-serialport packages: Move packages in alphabetical order.
  gnu: node-semver: Move package in alphabetical order.
  gnu: packages: node-xyz: Add alphatical order header.

 gnu/packages/node-xyz.scm | 1480 +++++++++++++++++++------------------
 1 file changed, 742 insertions(+), 738 deletions(-)


base-commit: 792a20ab93cf88feae119296b0d2db58dccf3732

Comments

Sharlatan Hellseher Feb. 10, 2024, 4:16 p.m. UTC | #1
Hi Nicolas,

This is a great initiative! Patch series looks good for me. Looking
forward for more packages in node-xyz ;-)

Thanks,
Oleg
ashish.is--- via Guix-patches" via Feb. 18, 2024, 12:02 p.m. UTC | #2
Hi Oleg,

Thanks for your review!

Is there a way to get this merged? A quick way to check which lines have
been actually changed and not moved is this command (where patches is a
directory with all patches from the series): 

find patches -type f -print0 | xargs -0 -n1 grep -E '^[+-]' | sed -E 's/^[+-]//' | sort | uniq -u

I'm developping on this patch series and it's a pain to rebase
everything in the case any new node package gets merged upstream.

Nicolas 

On 2024-02-10 16:16, Sharlatan Hellseher wrote:

> Hi Nicolas,
>
> This is a great initiative! Patch series looks good for me. Looking
> forward for more packages in node-xyz ;-)
>
> Thanks,
> Oleg
ashish.is--- via Guix-patches" via Feb. 18, 2024, 12:02 p.m. UTC | #3
Hi Oleg,

Thanks for your review!

Is there a way to get this merged? A quick way to check which lines have
been actually changed and not moved is this command (where patches is a
directory with all patches from the series): 

find patches -type f -print0 | xargs -0 -n1 grep -E '^[+-]' | sed -E 's/^[+-]//' | sort | uniq -u

I'm developping on this patch series and it's a pain to rebase
everything in the case any new node package gets merged upstream.

Nicolas 

On 2024-02-10 16:16, Sharlatan Hellseher wrote:

> Hi Nicolas,
>
> This is a great initiative! Patch series looks good for me. Looking
> forward for more packages in node-xyz ;-)
>
> Thanks,
> Oleg