| Message ID | 20210620010742.4259-15-0x2d@disroot.org |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#49123,01/24] gnu: Add pyotherside. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
slg via Guix-patches via schreef op za 19-06-2021 om 22:07 [-0300]: > * gnu/packages/python-web.scm (python-aioresponses): New variable. > --- > gnu/packages/python-web.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm > index d4a959aacf..3a01a8c33c 100644 > --- a/gnu/packages/python-web.scm > +++ b/gnu/packages/python-web.scm > @@ -6054,3 +6054,31 @@ your code non-blocking and speedy.") > "Socks is a library providing core proxy (SOCKS4, SOCKS5, HTTP tunneling) > functionality.") > (license license:asl2.0))) > + > +(define-public python-aioresponses > + (package > + (name "python-aioresponses") > + (version "0.7.2") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "aioresponses" version)) > + (sha256 > + (base32 > + "16p8mdyfirddrsay62ji7rwcrqmmzxzf2isdbfm9cj5p338rbr42")))) It build successfully and the source code doesn't appear to contain malware (*) or anything pre-built. (*) includes propietary software > + (build-system python-build-system) > + (arguments > + `(#:tests? #f)) ;; Tests make http requests > + (propagated-inputs > + `(("python-aiohttp" ,python-aiohttp))) > + (native-inputs > + `(("python-pbr" ,python-pbr))) > + (home-page "https://github.com/pnuckowski/aioresponses") > + (synopsis "Mock out requests made by ClientSession from aiohttp package") Either drop the 'package", or make this "... from the aiohttp package". > + (description "Aioresponses is a helper to mock/fake web requests in python > +aiohttp package. For requests module there are a lot of packages that help us ‘in python aiohttp package’ --> maybe ‘with aiohttp’. You can drop the "us" in "that help is" > +with testing (eg. httpretty, responses, requests-mock). When it comes to it's e.g., not eg. > +testing asynchronous HTTP requests it is a bit harder (at least at the beginning). ‘(at least in the beginning)’ doesn't really inform people searching for which package they can use. I'd suggest dropping it. > +The purpose of this package is to provide an easy way to test asynchronous HTTP > +requests.") This sentence seems rather informative, clear and to the point. I'd move it to the beginning of the description. > + (license license:x11))) It's the expat license not the x11 license. Greetings, Maxime.
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm index d4a959aacf..3a01a8c33c 100644 --- a/gnu/packages/python-web.scm +++ b/gnu/packages/python-web.scm @@ -6054,3 +6054,31 @@ your code non-blocking and speedy.") "Socks is a library providing core proxy (SOCKS4, SOCKS5, HTTP tunneling) functionality.") (license license:asl2.0))) + +(define-public python-aioresponses + (package + (name "python-aioresponses") + (version "0.7.2") + (source + (origin + (method url-fetch) + (uri (pypi-uri "aioresponses" version)) + (sha256 + (base32 + "16p8mdyfirddrsay62ji7rwcrqmmzxzf2isdbfm9cj5p338rbr42")))) + (build-system python-build-system) + (arguments + `(#:tests? #f)) ;; Tests make http requests + (propagated-inputs + `(("python-aiohttp" ,python-aiohttp))) + (native-inputs + `(("python-pbr" ,python-pbr))) + (home-page "https://github.com/pnuckowski/aioresponses") + (synopsis "Mock out requests made by ClientSession from aiohttp package") + (description "Aioresponses is a helper to mock/fake web requests in python +aiohttp package. For requests module there are a lot of packages that help us +with testing (eg. httpretty, responses, requests-mock). When it comes to +testing asynchronous HTTP requests it is a bit harder (at least at the beginning). +The purpose of this package is to provide an easy way to test asynchronous HTTP +requests.") + (license license:x11)))