diff mbox series

[bug#38319,4/4] gnu: kdeconnect: Remove useless code.

Message ID 20191122093730.6164-4-h.goebel@crazy-compilers.com
State Accepted
Headers show
Series Fix wrap-qt-program some packages using Qt | expand

Commit Message

Hartmut Goebel Nov. 22, 2019, 9:37 a.m. UTC 
After fixing wrap-qt-program, setting QT_PLUGIN_PATH here is no longer
necessary.

* gnu/packages/kde.scm(kdeconnect)[arguments]<phases>{wrap-executable}:
  Remove setting QT_PLUGIN_PATH.
---
 gnu/packages/kde.scm | 3 ---
 1 file changed, 3 deletions(-)

Comments

Ludovic Courtès Nov. 25, 2019, 10:38 p.m. UTC | #1 
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> After fixing wrap-qt-program, setting QT_PLUGIN_PATH here is no longer
> necessary.
>
> * gnu/packages/kde.scm(kdeconnect)[arguments]<phases>{wrap-executable}:
>   Remove setting QT_PLUGIN_PATH.

LGTM, thanks!
Hartmut Goebel Nov. 26, 2019, 11:33 a.m. UTC | #2 
Updated and pushed as 0d455d9865c1bfd21a9415aa8515e75058dd7ee5

Thansk for the review.
diff mbox series

Patch

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index dcce02e467..636b5d60ba 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -558,9 +558,6 @@  different notification systems.")
          (add-after 'install 'wrap-executable
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
-               (setenv "QT_PLUGIN_PATH"
-                       (string-append out "/lib/qt5/plugins"
-                                      ":" (getenv "QT_PLUGIN_PATH")))
                (wrap-qt-program out "../lib/libexec/kdeconnectd")
                (wrap-qt-program out "kdeconnect-cli")
                (wrap-qt-program out "kdeconnect-handler")