diff mbox series

[bug#64150,08/24] gnu: webkitgtk: Explicitly use ruby-2.

Message ID 669e0b91e010cd2fd6749082b01500ede1830c92.1687087731.git.mail@cbaines.net
State New
Headers show
Series Various changes to support updating the default ruby. | expand

Commit Message

Christopher Baines June 18, 2023, 11:28 a.m. UTC
So that ruby can change without affecting this package and its dependants.

* gnu/packages/webkit.scm (webkitgtk)[native-inputs]: Explicitly use ruby-2.7.

Signed-off-by: Christopher Baines <mail@cbaines.net>
---
 gnu/packages/webkit.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Liliana Marie Prikler June 18, 2023, 11:35 a.m. UTC | #1
Am Sonntag, dem 18.06.2023 um 12:28 +0100 schrieb Christopher Baines:
> So that ruby can change without affecting this package and its
> dependants.
> 
> * gnu/packages/webkit.scm (webkitgtk)[native-inputs]: Explicitly use
> ruby-2.7.
> 
> Signed-off-by: Christopher Baines <mail@cbaines.net>
On the off chance that one of the GNOME team has to comment, LGTM.

You should probably commit this without the Signed-off-by part, though,
given that this seems to be your own commit.

Cheers
Christopher Baines June 18, 2023, 11:49 a.m. UTC | #2
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Sonntag, dem 18.06.2023 um 12:28 +0100 schrieb Christopher Baines:
>> So that ruby can change without affecting this package and its
>> dependants.
>>
>> * gnu/packages/webkit.scm (webkitgtk)[native-inputs]: Explicitly use
>> ruby-2.7.
>>
>> Signed-off-by: Christopher Baines <mail@cbaines.net>
>
> On the off chance that one of the GNOME team has to comment, LGTM.

I didn't realise you (and others were included in the X-Debbugs-Cc)
headers here, so apologies for that.

Anyway, team approval was discussed in #61894, but it hasn't happened
yet. I still appreciate you taking a look and your input though.

> You should probably commit this without the Signed-off-by part, though,
> given that this seems to be your own commit.

Indeed, I've removed that locally now.
diff mbox series

Patch

diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index f1b810adbd..5ab93ad9eb 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -222,7 +222,7 @@  (define-public webkitgtk
            pkg-config
            python-wrapper
            gi-docgen
-           ruby
+           ruby-2.7
            unifdef))
     (propagated-inputs
      (list gtk+ libsoup))