diff mbox series

[bug#69238,05/10] gnu: go-github-com-alecthomas-assert: Depricate package.

Message ID 662195cd762bd4c108da297964a6f428b55e58fb.1708155311.git.sharlatanus@gmail.com
State New
Headers show
Series Fix failed builds from evaluation 1123386. | expand

Commit Message

Sharlatan Hellseher Feb. 18, 2024, 6:39 p.m. UTC 
The package go-github-com-alecthomas-assert is succeeded by
go-github-com-alecthomas-assert-v2 not in use by any others and
failed to build, see <https://ci.guix.gnu.org/build/3490314/log/raw>.

* gnu/packages/golang-check.scm (go-github-com-alecthomas-assert):
Remove variable.

Change-Id: Ia3f7b039c4de9b1b2956f0bfc2629d791aa9cf5a
---
 gnu/packages/golang-check.scm | 46 ++++++++---------------------------
 1 file changed, 10 insertions(+), 36 deletions(-)

Comments

Troy Figiel Feb. 18, 2024, 8:34 p.m. UTC | #1 
Hi Oleg,

Small typo I happened to spot: sed 's/depricate/deprecate/' for the
commit message.

Best wishes,

Troy

On 2024-02-18 19:39, Sharlatan Hellseher wrote:
> The package go-github-com-alecthomas-assert is succeeded by
> go-github-com-alecthomas-assert-v2 not in use by any others and
> failed to build, see <https://ci.guix.gnu.org/build/3490314/log/raw>.
> 
> * gnu/packages/golang-check.scm (go-github-com-alecthomas-assert):
> Remove variable.
> 
> Change-Id: Ia3f7b039c4de9b1b2956f0bfc2629d791aa9cf5a
> ---
>  gnu/packages/golang-check.scm | 46 ++++++++---------------------------
>  1 file changed, 10 insertions(+), 36 deletions(-)
> 
> diff --git a/gnu/packages/golang-check.scm b/gnu/packages/golang-check.scm
> index 4874e0c9ae..64d0c68081 100644
> --- a/gnu/packages/golang-check.scm
> +++ b/gnu/packages/golang-check.scm
> @@ -60,43 +60,8 @@ (define-module (gnu packages golang-check)
>  ;;; Libraries:
>  ;;;
>  
> -(define-public go-github-com-alecthomas-assert
> -  (let ((commit "405dbfeb8e38effee6e723317226e93fff912d06")
> -        (revision "1"))
> -    (package
> -      (name "go-github-com-alecthomas-assert")
> -      (version (git-version "0.0.1" revision commit))
> -      (source
> -       (origin
> -         (method git-fetch)
> -         (uri (git-reference
> -               (url "https://github.com/alecthomas/assert")
> -               (commit commit)))
> -         (file-name (git-file-name name version))
> -         (sha256
> -          (base32
> -           "1l567pi17k593nrd1qlbmiq8z9jy3qs60px2a16fdpzjsizwqx8l"))))
> -      (build-system go-build-system)
> -      (arguments
> -       `(#:import-path "github.com/alecthomas/assert"))
> -      (native-inputs
> -       (list go-github-com-alecthomas-colour
> -             go-github-com-mattn-go-isatty
> -             go-github-com-alecthomas-repr
> -             go-github-com-sergi-go-diff))
> -      (home-page "https://github.com/alecthomas/assert/")
> -      (synopsis "Go assertion library")
> -      (description "Assertion library that:
> -@itemize
> -@item makes spotting differences in equality much easier
> -@item uses repr and diffmatchpatch to display structural differences in colour
> -@item aborts tests on first assertion failure
> -@end itemize\n")
> -      (license license:expat))))
> -
>  (define-public go-github-com-alecthomas-assert-v2
>    (package
> -    (inherit go-github-com-alecthomas-assert)
>      (name "go-github-com-alecthomas-assert-v2")
>      (version "2.2.2")
>      (source
> @@ -108,13 +73,22 @@ (define-public go-github-com-alecthomas-assert-v2
>         (file-name (git-file-name name version))
>         (sha256
>          (base32 "055w46gr47rrn5g2hh7z6hj3x2b8advbcph8gs8szrpzlympyyz0"))))
> +    (build-system go-build-system)
>      (arguments
>       (list #:go go-1.18
>             #:import-path "github.com/alecthomas/assert/v2"))
>      (propagated-inputs
>       (list go-github-com-alecthomas-repr
>             go-github-com-hexops-gotextdiff))
> -    (native-inputs '())))
> +    (home-page "https://github.com/alecthomas/assert/")
> +    (synopsis "Go assertion library")
> +    (description "Assertion library that:
> +@itemize
> +@item makes spotting differences in equality much easier
> +@item uses repr and diffmatchpatch to display structural differences in colour
> +@item aborts tests on first assertion failure
> +@end itemize")
> +    (license license:expat)))
>  
>  (define-public go-github-com-cheekybits-is
>    (let ((commit "68e9c0620927fb5427fda3708222d0edee89eae9")
Sharlatan Hellseher Feb. 18, 2024, 8:58 p.m. UTC | #2 
Hi Troy,

> Small typo I happened to spot: sed 's/depricate/deprecate/' for the
> commit message.

Thanks, typos are my Doom =)...

Sending v2.
diff mbox series

Patch

diff --git a/gnu/packages/golang-check.scm b/gnu/packages/golang-check.scm
index 4874e0c9ae..64d0c68081 100644
--- a/gnu/packages/golang-check.scm
+++ b/gnu/packages/golang-check.scm
@@ -60,43 +60,8 @@  (define-module (gnu packages golang-check)
 ;;; Libraries:
 ;;;
 
-(define-public go-github-com-alecthomas-assert
-  (let ((commit "405dbfeb8e38effee6e723317226e93fff912d06")
-        (revision "1"))
-    (package
-      (name "go-github-com-alecthomas-assert")
-      (version (git-version "0.0.1" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/alecthomas/assert")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "1l567pi17k593nrd1qlbmiq8z9jy3qs60px2a16fdpzjsizwqx8l"))))
-      (build-system go-build-system)
-      (arguments
-       `(#:import-path "github.com/alecthomas/assert"))
-      (native-inputs
-       (list go-github-com-alecthomas-colour
-             go-github-com-mattn-go-isatty
-             go-github-com-alecthomas-repr
-             go-github-com-sergi-go-diff))
-      (home-page "https://github.com/alecthomas/assert/")
-      (synopsis "Go assertion library")
-      (description "Assertion library that:
-@itemize
-@item makes spotting differences in equality much easier
-@item uses repr and diffmatchpatch to display structural differences in colour
-@item aborts tests on first assertion failure
-@end itemize\n")
-      (license license:expat))))
-
 (define-public go-github-com-alecthomas-assert-v2
   (package
-    (inherit go-github-com-alecthomas-assert)
     (name "go-github-com-alecthomas-assert-v2")
     (version "2.2.2")
     (source
@@ -108,13 +73,22 @@  (define-public go-github-com-alecthomas-assert-v2
        (file-name (git-file-name name version))
        (sha256
         (base32 "055w46gr47rrn5g2hh7z6hj3x2b8advbcph8gs8szrpzlympyyz0"))))
+    (build-system go-build-system)
     (arguments
      (list #:go go-1.18
            #:import-path "github.com/alecthomas/assert/v2"))
     (propagated-inputs
      (list go-github-com-alecthomas-repr
            go-github-com-hexops-gotextdiff))
-    (native-inputs '())))
+    (home-page "https://github.com/alecthomas/assert/")
+    (synopsis "Go assertion library")
+    (description "Assertion library that:
+@itemize
+@item makes spotting differences in equality much easier
+@item uses repr and diffmatchpatch to display structural differences in colour
+@item aborts tests on first assertion failure
+@end itemize")
+    (license license:expat)))
 
 (define-public go-github-com-cheekybits-is
   (let ((commit "68e9c0620927fb5427fda3708222d0edee89eae9")