diff mbox series

[bug#41193,11/13] gnu: network-manager-vpnc: Use libnma.

Message ID 20200511190046.27155-11-brice@waegenei.re
State Accepted
Headers show
Series Update network-manager suite | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Brice Waegeneire May 11, 2020, 7 p.m. UTC 
* gnu/packages/gnome.scm (network-manager-vpnc)[arguments]: Add
configure flag '--with-libnm-glib=no'.
[inputs]: Replace 'network-manager' by 'libnma'.
---
 gnu/packages/gnome.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Leo Famulari May 11, 2020, 8:01 p.m. UTC | #1 
On Mon, May 11, 2020 at 09:00:44PM +0200, Brice Waegeneire wrote:
> +     `(#:configure-flags '("--enable-absolute-paths" "--localstatedir=/var"
> +                           "--with-libnm-glib=no")

Can you add a brief code comment explaining this configure flag?
Jonathan Brielmaier May 22, 2020, 6:20 p.m. UTC | #2 
On 11.05.20 22:01, Leo Famulari wrote:
> On Mon, May 11, 2020 at 09:00:44PM +0200, Brice Waegeneire wrote:
>> +     `(#:configure-flags '("--enable-absolute-paths" "--localstatedir=/var"
>> +                           "--with-libnm-glib=no")
>
> Can you add a brief code comment explaining this configure flag?

And maybe one line per configure option :)
diff mbox series

Patch

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9fbf12f406..121b4e8027 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -6568,7 +6568,8 @@  to virtual private networks (VPNs) via OpenVPN.")
                 "1js5lwcsqws4klgypfxl4ikmakv7v7xgddij1fj6b0y0qicx0kyy"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:configure-flags '("--enable-absolute-paths" "--localstatedir=/var")
+     `(#:configure-flags '("--enable-absolute-paths" "--localstatedir=/var"
+                           "--with-libnm-glib=no")
        #:phases
        (modify-phases %standard-phases
          (add-after 'configure 'patch-path
@@ -6592,7 +6593,7 @@  to virtual private networks (VPNs) via OpenVPN.")
        ("kmod" ,kmod)
        ("vpnc" ,vpnc)
        ("network-manager" ,network-manager)
-       ("network-manager-applet" ,network-manager-applet) ;for libnma
+       ("libnma" ,libnma)
        ("libsecret" ,libsecret)))
     (home-page "https://wiki.gnome.org/Projects/NetworkManager/VPN")
     (synopsis "VPNC plug-in for NetworkManager")