mbox series

[bug#70390,0/2] Add s-exp support to Notmuch

Message ID cover.1713165432.git.me@fabionatali.com
Headers show
Series Add s-exp support to Notmuch | expand

Message

Fabio Natali April 15, 2024, 7:19 a.m. UTC 
Dear All,

On 2022-04-25⁰, support for S-expression-based queries was added to
Notmuch (version 0.36). This is based on a C/C++ library called sfsexp¹.

You can check whether your Notmuch was built with s-exp support with
this command²:

,----
| notmuch config get built_with.sexp_queries
`----

The Notmuch version currently packaged in Guix does not support s-exp
queries.

This patch micro-series is to:

- Add sfsexp¹.
- Update Notmuch to make use of sfsexp and to allow S-expression-based queries.

Thanks, best wishes, Fabio.


⁰ https://git.notmuchmail.org/git?p=notmuch;a=blob;f=NEWS;h=cf8107f26362431549dc410cb8379de5c10221f1;hb=HEAD#l165
¹ https://github.com/mjsottile/sfsexp
² https://notmuchmail.org/doc/latest/man7/notmuch-sexp-queries.html


Fabio Natali (2):
  gnu: Add sfsexp.
  gnu: notmuch: Add sfsexp dependency.

 gnu/packages/c.scm    | 22 ++++++++++++++++++++++
 gnu/packages/mail.scm |  4 +++-
 2 files changed, 25 insertions(+), 1 deletion(-)


base-commit: e5dda412c2e28fb65a549824f492895e72c33813

Comments

Nicolas Graves May 13, 2024, 8:42 a.m. UTC | #1 
user guix
usertag 70390 + reviewed-looks-good
thanks

Guix QA review form submission:

git should be rewritten to git-minimal and inserted a few lines down instead. 
Otherwise LGTM.

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests, New package synopsis and descriptions
Nicolas Graves May 13, 2024, 8:47 a.m. UTC | #2 
On 2024-05-13 10:42, Nicolas Graves wrote:

> user guix
> usertag 70390 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
>
> git should be rewritten to git-minimal and inserted a few lines down
> instead.

And probably git-minimal/pinned, see https://issues.guix.gnu.org/70656
for instance.

> Otherwise LGTM.
>
> Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests, New package synopsis and descriptions
Christopher Baines May 13, 2024, 8:43 p.m. UTC | #3 
Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:

> On 2024-05-13 10:42, Nicolas Graves wrote:
>
>> user guix
>> usertag 70390 + reviewed-looks-good
>> thanks
>>
>> Guix QA review form submission:
>>
>> git should be rewritten to git-minimal and inserted a few lines down
>> instead.
>
> And probably git-minimal/pinned, see https://issues.guix.gnu.org/70656
> for instance.
>
>> Otherwise LGTM.
>>
>> Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests, New package synopsis and descriptions

Thanks both, I've tweaked the git input and pushed these patches to
master as b1de64812a0a9e30507fb1ea44611779149c32cc.

Chris