mbox series

[bug#69669,gnome-team,v2,0/3] Update girara (better)

Message ID cover.1709974804.git.vivien@planete-kraus.eu
Headers show
Series Update girara (better) | expand

Message

Vivien Kraus March 9, 2024, 9 a.m. UTC 
Dear guix,

I split the cosmetic changes, and also split the non-cosmetic change in 2.
json-glib is an optional dependency, so girara can exist with and without it.

You were right, pango is already propagated from gtk+.

I also reordered the fields, but it does not look very intuitive, because it
looks like I moved the arguments field up and the native-inputs field down
instead of moving native-inputs and propagated-inputs down (thanks git).
Should I also split the style update?

Best regards,

Vivien

Vivien Kraus (3):
  gnu: girara: Update style.
  gnu: girara: Update to 0.4.3.
  gnu: girara: Build with json-glib.

 gnu/packages/gtk.scm | 53 +++++++++++++++++++++++---------------------
 1 file changed, 28 insertions(+), 25 deletions(-)


base-commit: 25c14c893f05019d746321285acf55d1aa65b943

Comments

Liliana Marie Prikler March 9, 2024, 9:24 a.m. UTC | #1 
Am Samstag, dem 09.03.2024 um 10:00 +0100 schrieb Vivien Kraus:
> Dear guix,
> 
> I split the cosmetic changes, and also split the non-cosmetic change
> in 2.  json-glib is an optional dependency, so girara can exist with
> and without it.
Would you care to elaborate?  Depending on the exact changes between
the version, I might want to squash this into one commit.

> You were right, pango is already propagated from gtk+.
> 
> I also reordered the fields, but it does not look very intuitive,
> because it looks like I moved the arguments field up and the native-
> inputs field down instead of moving native-inputs and propagated-
> inputs down (thanks git).
> Should I also split the style update?
Nah, that's fine.

Cheers
Vivien Kraus March 9, 2024, 12:33 p.m. UTC | #2 
Le samedi 09 mars 2024 à 10:24 +0100, Liliana Marie Prikler a écrit :
> > I split the cosmetic changes, and also split the non-cosmetic
> > change
> > in 2.  json-glib is an optional dependency, so girara can exist
> > with
> > and without it.
> Would you care to elaborate?  Depending on the exact changes between
> the version, I might want to squash this into one commit.

In meson_options.txt, here is the description for the 'json' option: 

```
description: 'dump configuration using JSON'
```

The README has:

```
The following dependencies are optional:

* `json-glib-1.0`: configuration dumping support
```

The blame tells us it was added in september 2022, so later than the
0.3.7 release (february 2022).

I don’t really understand what it’s used for, I have never developed
with girara.

Does this help?

Vivien
Maxim Cournoyer March 9, 2024, 5:58 p.m. UTC | #3 
Hello,

Vivien Kraus <vivien@planete-kraus.eu> writes:

> Dear guix,
>
> I split the cosmetic changes, and also split the non-cosmetic change in 2.
> json-glib is an optional dependency, so girara can exist with and without it.
>
> You were right, pango is already propagated from gtk+.
>
> I also reordered the fields, but it does not look very intuitive, because it
> looks like I moved the arguments field up and the native-inputs field down
> instead of moving native-inputs and propagated-inputs down (thanks git).
> Should I also split the style update?
>
> Best regards,
>
> Vivien
>
> Vivien Kraus (3):
>   gnu: girara: Update style.
>   gnu: girara: Update to 0.4.3.
>   gnu: girara: Build with json-glib.
>

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Liliana Marie Prikler March 9, 2024, 6:40 p.m. UTC | #4 
Am Samstag, dem 09.03.2024 um 12:58 -0500 schrieb Maxim Cournoyer:
> Hello,
> 
> Vivien Kraus <vivien@planete-kraus.eu> writes:
> 
> > Dear guix,
> > 
> > I split the cosmetic changes, and also split the non-cosmetic
> > change in 2.
> > json-glib is an optional dependency, so girara can exist with and
> > without it.
> > 
> > You were right, pango is already propagated from gtk+.
> > 
> > I also reordered the fields, but it does not look very intuitive,
> > because it looks like I moved the arguments field up and the
> > native-inputs field down instead of moving native-inputs and
> > propagated-inputs down (thanks git).
> > Should I also split the style update?
> > 
> > Best regards,
> > 
> > Vivien
> > 
> > Vivien Kraus (3):
> >   gnu: girara: Update style.
> >   gnu: girara: Update to 0.4.3.
> >   gnu: girara: Build with json-glib.
> > 
> 
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Hi, I've went ahead and pushed 1 and 2.  For 3, I'd like you to clarify
whether we ought to use propagated-inputs now or how else to handle
this.

Cheers