mbox series

[bug#66119,0/3] Some OCaml packages (needed for ocaml-toml)

Message ID cover.1695203766.git.racin@free.fr
Headers show
Series Some OCaml packages (needed for ocaml-toml) | expand

Message

Matthieu Lemerre Sept. 20, 2023, 10:45 a.m. UTC 
Hello,

Here are three missing OCaml packages. (I have more to come, but I want to make sure that I got the process right)

Best regards,
Matthieu

Matthieu Lemerre (3):
  gnu: Add ocaml-iso8601.
  gnu: Add ocaml-ocb.
  gnu: Add ocaml-toml.

 gnu/packages/ocaml.scm | 70 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)


base-commit: 15c5f1a2c20b21de0f19f42db1ccab4c42117ebb

Comments

pukkamustard Oct. 14, 2023, 6:25 a.m. UTC | #1 
Hello,

Matthieu Lemerre <racin@free.fr> writes:

> Here are three missing OCaml packages. (I have more to come, but I want to make sure that I got the process right)

Thanks!

Descriptions are good, packages build and lint does not complain. Looks
good to me!

One small thing: It seems like ocaml-ocb is not a real dependency of
ocaml-toml (not even a test dependency). It seems to be used only when
deploying new versions of ocaml-toml and ocaml-toml builds fine without
ocaml-ocb. I would drop ocaml-ocb from inputs of ocaml-toml and if you
have no use of ocaml-ocb directly, drop the entire ocaml-ocb patch.

Cheers,
pukkamustard
Ludovic Courtès Oct. 24, 2023, 3:31 p.m. UTC | #2 
Hi Matthieu,

Did you get a change to look into what pukkamustard wrote (below)?

If you think everything is fine as-is, please let us know and we’ll
apply the patches.

Thanks,
Ludo’.

pukkamustard <pukkamustard@posteo.net> skribis:

> Hello,
>
> Matthieu Lemerre <racin@free.fr> writes:
>
>> Here are three missing OCaml packages. (I have more to come, but I want to make sure that I got the process right)
>
> Thanks!
>
> Descriptions are good, packages build and lint does not complain. Looks
> good to me!
>
> One small thing: It seems like ocaml-ocb is not a real dependency of
> ocaml-toml (not even a test dependency). It seems to be used only when
> deploying new versions of ocaml-toml and ocaml-toml builds fine without
> ocaml-ocb. I would drop ocaml-ocb from inputs of ocaml-toml and if you
> have no use of ocaml-ocb directly, drop the entire ocaml-ocb patch.
>
> Cheers,
> pukkamustard