mbox series

[bug#62728,0/2] Update and fix the build of openmw-openscenegraph.

Message ID cover.1680980546.git.kaelyn.alexi@protonmail.com
Headers show
Series Update and fix the build of openmw-openscenegraph. | expand

Message

Kaelyn Takata April 8, 2023, 7:22 p.m. UTC 
Hi,

I decided to try out OpenMW after recently learning how far along the project
is. To my joy, the latest version was already packaged. To my dismay the
version of openscenegraph it depended on no longer built (I believe commit
98b9f3a4bdwhich added a separate output for plugins was what broke the child
package, as the error was with the mkdir in the new phase).

I have fixed the build by removing the new output and phase from
openmw-openscenegraph. I have also updated the package to the latest commit
from https://github.com/OpenMW/osg. Two points to note about the changes:

  1) Simply updating the package to the (much) newer commit fixes the build in
  the presence of the separate plugin output, but I kept the plugins in the
  main output since they are needed by OpenMW and I worry that the separate
  output will cause problems with OpenMW being able to find them.

  2) The existing openmw-openscenegraph package appears to be at a commit from
  2018 that does not seem to be a commit in https://github.com/OpenMW/osg.
  https://github.com/OpenMW/osg/commit/36a962845a2c87a6671fd822157e0729d164e940
  has a banner saying the commit does not belong to any branch and may belong
  to a fork outside of the repository. In a local checkout of the repository,
  `git log 36a962845a2c87a6671fd822157e0729d164e940` says the hash is not a
  valid object.

Also, feel free to adjust the commit messages as necessary. I wasn't certain
on the appropriate format or wording for either of the commits' messages.

Cheers,
Kaelyn



Kaelyn Takata (2):
  gnu: openmw-openscenegraph: Fix build.
  gnu: openmw-openscenegraph: Update to Nov 2022 commit.

 gnu/packages/graphics.scm | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)


base-commit: b08cdfc6d363e9ca63118303b4628542c54a612d
--
2.39.2

Comments

Kaelyn Takata April 27, 2023, 4 p.m. UTC | #1 
I've rebased the patch against current master, and dropped the build fix since Efraim independently applied the same fix on April 18th.

I feel the package update is still worthwhile since the current commit is extremely old and, according to GitHub, is not a commit in the repo at https://github.com/OpenMW/osg/ (GitHub suggests it may be from a fork of the repo).

Cheers,
Kaelyn
Kaelyn Takata April 27, 2023, 4:02 p.m. UTC | #2 
retitle 62728 [PATCH] gnu: openmw-openscenegraph: Update to Nov 2022 commit.