mbox series

[bug#60429,v3,0/5] gnu: yosys: Update to 0.24.

Message ID cover.1676033083.git.simon@simonsouth.net
Headers show
Series gnu: yosys: Update to 0.24. | expand

Message

Simon South Feb. 10, 2023, 1:16 p.m. UTC 
Here's a third revision of the remaining two patches in this series.  These
updated patches now

- Remove the remaining propagated inputs (abc and z3) from the yosys package
  via changes to its "fix-paths" and "use-external-abc" phases, and

- Update Yosys to version 0.26.

Note the second patch adds python and python-click as new propagated inputs.
The Click library is needed by the "yosys-witness" command, and including both
it and the Python interpreter in propagated-inputs is the only combination
I've found that will cause Guix to set GUIX_PYTHONPATH appropriately on
installation so this command can function.

This appears to be supported by the Guix manual (in the sections "Search
Paths" and "Python Modules") but if there's a better approach, please let me
know.

As usual, I've tested these changes on x86-64 and AArch64 and all appears
well.

--
Simon South
simon@simonsouth.net


Simon South (2):
  gnu: yosys: Do not propagate any inputs.
  gnu: yosys: Update to 0.26.

 gnu/packages/fpga.scm | 56 +++++++++++++++++++------------------------
 1 file changed, 24 insertions(+), 32 deletions(-)


base-commit: b8f6ead5faac3c1b9a8fa6e060c00cf0917e884e

Comments

Christopher Baines Feb. 11, 2023, 8:38 p.m. UTC | #1 
Simon South <simon@simonsouth.net> writes:

> Here's a third revision of the remaining two patches in this series.  These
> updated patches now
>
> - Remove the remaining propagated inputs (abc and z3) from the yosys package
>   via changes to its "fix-paths" and "use-external-abc" phases, and
>
> - Update Yosys to version 0.26.

Thanks for the update, I made a tweak and pushed these to master as
8553148dfb91a9957b95c7bc6bc108cc0a973f9e.

> Note the second patch adds python and python-click as new propagated inputs.
> The Click library is needed by the "yosys-witness" command, and including both
> it and the Python interpreter in propagated-inputs is the only combination
> I've found that will cause Guix to set GUIX_PYTHONPATH appropriately on
> installation so this command can function.
>
> This appears to be supported by the Guix manual (in the sections "Search
> Paths" and "Python Modules") but if there's a better approach, please let me
> know.

I believe the good approach to do this is to wrap the relevant
script. I've gone ahead and changed the patch to do this rather than add
the propagated inputs. Do let me know if there's a problem with this
approach though, as I don't know how to test this software as well as
you.

Thanks again,

Chris