Message ID | cover.1627850945.git.iskarian@mgsn.dev |
---|---|
Headers | show
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A7DAB27BC78; Sun, 1 Aug 2021 22:17:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3018027BC6B for <patchwork@mira.cbaines.net>; Sun, 1 Aug 2021 22:17:11 +0100 (BST) Received: from localhost ([::1]:58264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org>) id 1mAIpa-0007Jl-21 for patchwork@mira.cbaines.net; Sun, 01 Aug 2021 17:17:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mAIpT-0007Jd-0D for guix-patches@gnu.org; Sun, 01 Aug 2021 17:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53738) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mAIpS-00058t-OY for guix-patches@gnu.org; Sun, 01 Aug 2021 17:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mAIpS-00063u-LM for guix-patches@gnu.org; Sun, 01 Aug 2021 17:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49813] [PATCH 00/34] Fix regexes in FIND-FILES invocations. Resent-From: Sarah Morgensen <iskarian@mgsn.dev> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 01 Aug 2021 21:17:02 +0000 Resent-Message-ID: <handler.49813.B.162785261323282@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49813 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49813@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162785261323282 (code B ref -1); Sun, 01 Aug 2021 21:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Aug 2021 21:16:53 +0000 Received: from localhost ([127.0.0.1]:37051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1mAIpI-00063S-P8 for submit@debbugs.gnu.org; Sun, 01 Aug 2021 17:16:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:45768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <iskarian@mgsn.dev>) id 1mAIp6-000637-SK for submit@debbugs.gnu.org; Sun, 01 Aug 2021 17:16:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <iskarian@mgsn.dev>) id 1mAIp6-0007J6-Ln for guix-patches@gnu.org; Sun, 01 Aug 2021 17:16:40 -0400 Received: from out2.migadu.com ([2001:41d0:2:aacc::]:16992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <iskarian@mgsn.dev>) id 1mAIp2-0004pc-CT for guix-patches@gnu.org; Sun, 01 Aug 2021 17:16:40 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1627852592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DffXxZUHXbu4ZO2rRFqKO6XrQBtnfXk0lFcUO1aEVTE=; b=R2L02O/YAvBiAYJSXzuOA/UOw5lNBPofeujNQdyVWe1J8yq82I9Dzngw9sLx9Hyq41a2KW sfWP0VMfTEkrpf8ofpz1GiR9P05ggCW1I4TBuJv0mfBrJmQhyPec9a2RszQzDfgizzYFHq zPh9nT2AimzdjEPh+5WxpTParkEIjSI= From: Sarah Morgensen <iskarian@mgsn.dev> Date: Sun, 1 Aug 2021 14:16:28 -0700 Message-Id: <cover.1627850945.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=iskarian@mgsn.dev; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-getmail-retrieved-from-mailbox: Patches |
Series |
Fix regexes in FIND-FILES invocations.
|
expand
|
Hi Maxime, Thanks for taking a look at this. Maxime Devos <maximedevos@telenet.be> writes: > Sarah Morgensen schreef op zo 01-08-2021 om 14:18 [-0700]: >> - (find-files "include" "\\.h")) >> + (find-files "include" "\\.h$")) > > C++ header files are sometimes named "something.hpp" instead > of "something.h", so you might want to verify these don't exist. > (And if they do exist, keep the regex "\\.h", or make it "\\.(h|hpp)$"?) > > Likewise for 'kaldi', 'shogun' and 'rtags'. Otherwise, these > new regexes look good to me (but I didn't test them). Good catch. I just checked the sources for all of those, and I can verify that they don't exist. (Shogun and rtags do have .hpp files in their source, but only in other directories.) -- Sarah