diff mbox series

[bug#49813,04/34] gnu: tao: Fix regex in FIND-FILES invocation.

Message ID cb84dcfd2ffc948a0c13bc72181a01f2d1f66884.1627850945.git.iskarian@mgsn.dev
State New
Headers show
Series Fix regexes in FIND-FILES invocations. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue
cbaines/applying patch success View Laminar job
cbaines/issue success View issue
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Sarah Morgensen Aug. 1, 2021, 9:18 p.m. UTC 
See <https://issues.guix.gnu.org/37150> for more information.

* gnu/packages/audio.scm (tao)[arguments]: Fix regex.
---
 gnu/packages/audio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

M Aug. 22, 2021, 9:53 a.m. UTC | #1 
Sarah Morgensen schreef op zo 01-08-2021 om 14:18 [-0700]:
> -                         (find-files "include" "\\.h"))
> +                         (find-files "include" "\\.h$"))

C++ header files are sometimes named "something.hpp" instead
of "something.h", so you might want to verify these don't exist.
(And if they do exist, keep the regex "\\.h", or make it "\\.(h|hpp)$"?)

Likewise for 'kaldi', 'shogun' and 'rtags'.  Otherwise, these
new regexes look good to me (but I didn't test them).

Greetings,
Maxime.
diff mbox series

Patch

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index f56ac61c4c..432949c2a0 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1222,7 +1222,7 @@  emulation (valve, tape), bit fiddling (decimator, pointer-cast), etc.")
                (install-file "user-scripts/error.parse" share)
                (copy-recursively "examples" (string-append share "examples"))
                (for-each (lambda (file) (install-file file inc))
-                         (find-files "include" "\\.h"))
+                         (find-files "include" "\\.h$"))
                #t))))))
     (inputs
      `(("audiofile" ,audiofile)