mbox series

[bug#51587,0/3] Add rss2email.

Message ID BYAPR05MB4023765B9C648E76EF5B2B7AC58C9@BYAPR05MB4023.namprd05.prod.outlook.com
Headers show
Series Add rss2email. | expand

Message

Morgan Smith Nov. 3, 2021, 4:27 p.m. UTC
[PATCH 1/3] gnu: Add python-sgmllib3k.
[PATCH 2/3] gnu: python-feedparser: Add input
[PATCH 3/3] gnu: Add rss2email.

Comments

Morgan Smith Nov. 11, 2021, 3:30 p.m. UTC | #1
Thanks for the review!

I looked over both previously submitted sgmllib3k packages and I think my patch is the best as the description mentions SGML.

I fixed the sgmllib3k indentation issue and added a missing word to the description.

For the rss2email patch:
- I added my copyright to mail.scm
- I removed the inputs and outputs from the check phase
- Made the input not propagated. It is indeed a binary that seems to still work this way.
- Fixed that comment
- Slightly modified the description but I'm honestly not sure what the issue is. I'll admit I'm not very good at english so if you could just change it how you see fit that would make me happy


[PATCH v2 1/3] gnu: Add python-sgmllib3k.
[PATCH v2 2/3] gnu: python-feedparser: Add input
[PATCH v2 3/3] gnu: Add rss2email.