| Message ID | 20240518123734.9898-1-ngraves@ngraves.fr |
|---|---|
| Headers | show |
| Series | gnu: python-pydevd: Update to 2.9.6. | expand |
Hello! Nicolas Graves <ngraves@ngraves.fr> writes: > Nicolas Graves (3): > gnu: python-pydevd: Move to pyproject-build-system. > gnu: python-pydevd: Update to 2.9.6. > gnu: python-pydevd: Improve package style. > Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail> Also, thanks for refreshing/resubmitting the pydevd patch to upstream!
On 2024-05-20 22:40, Maxim Cournoyer wrote: > Hello! > > Nicolas Graves <ngraves@ngraves.fr> writes: > >> Nicolas Graves (3): >> gnu: python-pydevd: Move to pyproject-build-system. >> gnu: python-pydevd: Update to 2.9.6. >> gnu: python-pydevd: Improve package style. >> > > Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail> > > Also, thanks for refreshing/resubmitting the pydevd patch to upstream! As a comment for my debugpy patch : we should probably care about that too: https://github.com/microsoft/debugpy/issues/1585 Until this gets a proper answer, we should probably only update to 1.8.0, although I don't see why this should really diverge given the commits. I can't work on this today, but feel free to rebase the patch in 1.8.0 (should be easy, not much changes). Otherwise, I'll do it, but probably not before next week.
Hi Nicolas, Nicolas Graves <ngraves@ngraves.fr> writes: > On 2024-05-20 22:40, Maxim Cournoyer wrote: > >> Hello! >> >> Nicolas Graves <ngraves@ngraves.fr> writes: >> >>> Nicolas Graves (3): >>> gnu: python-pydevd: Move to pyproject-build-system. >>> gnu: python-pydevd: Update to 2.9.6. >>> gnu: python-pydevd: Improve package style. >>> >> >> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail> >> >> Also, thanks for refreshing/resubmitting the pydevd patch to upstream! > > As a comment for my debugpy patch : we should probably care about that > too: https://github.com/microsoft/debugpy/issues/1585 > > Until this gets a proper answer, we should probably only update to > 1.8.0, although I don't see why this should really diverge given the > commits. > > I can't work on this today, but feel free to rebase the patch in 1.8.0 > (should be easy, not much changes). Otherwise, I'll do it, but probably > not before next week. I'm not in a position to push on this right now, so I'll let you lead the charge, even if that's in a week or two. Thanks for doing so!
Hi Nicolas, Maxim Cournoyer <maxim.cournoyer@gmail.com> writes: > Hi Nicolas, > > Nicolas Graves <ngraves@ngraves.fr> writes: > >> On 2024-05-20 22:40, Maxim Cournoyer wrote: >> >>> Hello! >>> >>> Nicolas Graves <ngraves@ngraves.fr> writes: >>> >>>> Nicolas Graves (3): >>>> gnu: python-pydevd: Move to pyproject-build-system. >>>> gnu: python-pydevd: Update to 2.9.6. >>>> gnu: python-pydevd: Improve package style. >>>> >>> >>> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail> >>> >>> Also, thanks for refreshing/resubmitting the pydevd patch to upstream! >> >> As a comment for my debugpy patch : we should probably care about that >> too: https://github.com/microsoft/debugpy/issues/1585 >> >> Until this gets a proper answer, we should probably only update to >> 1.8.0, although I don't see why this should really diverge given the >> commits. >> >> I can't work on this today, but feel free to rebase the patch in 1.8.0 >> (should be easy, not much changes). Otherwise, I'll do it, but probably >> not before next week. > > I'm not in a position to push on this right now, so I'll let you lead > the charge, even if that's in a week or two. Thanks for doing so! Did you have a chance to work on this remaining detail? It's a great series!
On 2024-06-23 23:12, Maxim Cournoyer wrote: > Did you have a chance to work on this remaining detail? It's a great > series! I have rebased on 1.8.0 instead of 1.8.1 indeed. The issue now is that it breaks ipykernel which needs an update and its update requires going through python-team branch. We should thus apply them (70995 and 71037) in python-team, which is quite a mess to work with when you don't have commit access. I have some time this week, maybe the right thing to do would be to apply for commit access and rebase python-team myself.
Hi! Nicolas Graves <ngraves@ngraves.fr> writes: > On 2024-06-23 23:12, Maxim Cournoyer wrote: > >> Did you have a chance to work on this remaining detail? It's a great >> series! > > I have rebased on 1.8.0 instead of 1.8.1 indeed. The issue now is that > it breaks ipykernel which needs an update and its update requires going > through python-team branch. > > We should thus apply them (70995 and 71037) in python-team, which is > quite a mess to work with when you don't have commit access. I have some > time this week, maybe the right thing to do would be to apply for commit > access and rebase python-team myself. That'd be worth it I think! I encourage you to broadcast your intention to guix-devel and ask/gather for 3 committers to vouch for you so that we can make it a reality.