Message ID | 20220701213302.13234-4-goodoldpaul@autistici.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 516CB27BBEA; Fri, 1 Jul 2022 22:34:32 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 119D427BBE9 for <patchwork@mira.cbaines.net>; Fri, 1 Jul 2022 22:34:32 +0100 (BST) Received: from localhost ([::1]:55216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org>) id 1o7OHX-00083N-8h for patchwork@mira.cbaines.net; Fri, 01 Jul 2022 17:34:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1o7OH5-0007RA-Gp for guix-patches@gnu.org; Fri, 01 Jul 2022 17:34:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1o7OH5-00023U-84 for guix-patches@gnu.org; Fri, 01 Jul 2022 17:34:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1o7OH5-0007fn-5M for guix-patches@gnu.org; Fri, 01 Jul 2022 17:34:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53019] [PATCH 4/6] gnu: Add python-pytest-cov-3.0. Resent-From: Giacomo Leidi <goodoldpaul@autistici.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Jul 2022 21:34:03 +0000 Resent-Message-ID: <handler.53019.B53019.165671119829398@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53019 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53019@debbugs.gnu.org Cc: Giacomo Leidi <goodoldpaul@autistici.org> Received: via spool by 53019-submit@debbugs.gnu.org id=B53019.165671119829398 (code B ref 53019); Fri, 01 Jul 2022 21:34:03 +0000 Received: (at 53019) by debbugs.gnu.org; 1 Jul 2022 21:33:18 +0000 Received: from localhost ([127.0.0.1]:39221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1o7OGM-0007dz-4W for submit@debbugs.gnu.org; Fri, 01 Jul 2022 17:33:18 -0400 Received: from confino.investici.org ([93.190.126.19]:21719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <goodoldpaul@autistici.org>) id 1o7OGJ-0007dJ-8e for 53019@debbugs.gnu.org; Fri, 01 Jul 2022 17:33:15 -0400 Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4LZT2f5SbQz110X; Fri, 1 Jul 2022 21:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1656711194; bh=jTSXzzLcuLEidk63xgpDMMqY14mIrlj4e4VQcG6Wtyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R2+o/biQuA3OoFoEHSZSKtRl/aaukQ6g6kPhLcS+inmySzXAKkEv6GJvKq10F4hvM ysp4//FCMk+9HkHIMGt7MbwEWuPBpfuMjXCsC+uHdGAyCemKwEsrVS0nAxmd9zKUJz CXTYlxX/cW0lk21NbRPqzHD4MIw25QLiEd4RGwfY= Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 4LZT2f4Q45z1109; Fri, 1 Jul 2022 21:33:14 +0000 (UTC) Date: Fri, 1 Jul 2022 23:33:00 +0200 Message-Id: <20220701213302.13234-4-goodoldpaul@autistici.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220701213302.13234-1-goodoldpaul@autistici.org> References: <20220701213302.13234-1-goodoldpaul@autistici.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> Reply-to: Giacomo Leidi <goodoldpaul@autistici.org> X-ACL-Warn: , Giacomo Leidi via Guix-patches <guix-patches@gnu.org> From: Giacomo Leidi via Guix-patches via <guix-patches@gnu.org> X-getmail-retrieved-from-mailbox: Patches |
Series | [bug#53019,1/6] gnu: Add python-codeclimate-test-reporter. | |
Commit Message
paul
July 1, 2022, 9:33 p.m. UTC
* gnu/packages/check.scm (python-pytest-cov-3.0): New variable. --- gnu/packages/check.scm | 11 +++++++++++ 1 file changed, 11 insertions(+)
Comments
On 01-07-2022 23:33, Giacomo Leidi via Guix-patches via wrote: > +(define-public python-pytest-cov-3.0 > + (package > + (inherit python-pytest-cov) Likewise as for python-coverage-5.5, why the separate package?
Dear Maxime,
> Likewise as for python-coverage-5.5, why the separate package?
Both python-pytest-cov and python-coverage have a lot of dependents,
they must be updated on staging...
$ guix refresh --list-dependent python-pytest-cov
Building the following 521 packages would ensure 1172 dependent packages
are rebuilt: python-pysox [...]
$ guix refresh --list-dependent python-coverage
Building the following 627 packages would ensure 1408 dependent packages
are rebuilt: u-boot-puma-rk3399 [...]\
I sent a patch for python-pytest-cov back in march,
(https://git.savannah.gnu.org/cgit/guix.git/commit/?h=staging&id=12c9da35389dfba86ae0d863132a6b2c4374205a)
but I didn't manage to find the time to do it also for python-coverage.
Thank you,
Giacomo
On 31-07-2022 00:52, goodoldpaul@autistici.org wrote: > Dear Maxime, >> Likewise as for python-coverage-5.5, why the separate package? > Both python-pytest-cov and python-coverage have a lot of dependents, > they must be updated on staging... Then you can mention that in the commit message, or better, ask for someone to merge staging (it's not core-updates) into master ... > > $ guix refresh --list-dependent python-pytest-cov > Building the following 521 packages would ensure 1172 dependent > packages are rebuilt: python-pysox [...] > > $ guix refresh --list-dependent python-coverage > Building the following 627 packages would ensure 1408 dependent > packages are rebuilt: u-boot-puma-rk3399 [...]\ > > I sent a patch for python-pytest-cov back in march, > (https://git.savannah.gnu.org/cgit/guix.git/commit/?h=staging&id=12c9da35389dfba86ae0d863132a6b2c4374205a) ... mentioning this in the commit message would avoid having the reviewer doing some pointless checking whether the new version doesn't contain malware, whether it builds reproducibly, etc, as it was presumably already done for the staging patch. Greetings, Maxime.
Dear Maxime, On 2022-07-30 23:13, Maxime Devos wrote: > ... mentioning this in the commit message would avoid having the > reviewer doing some pointless checking whether the new version doesn't > contain malware, whether it builds reproducibly, etc, as it was > presumably already done for the staging patch. I sent a patch to staging ( https://issues.guix.gnu.org/58421 ) and I should have addressed all your comments. I'm sending an updated patch set. Thank you for your time, giacomo
diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 58af53388e..51fa2d2282 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1089,6 +1089,17 @@ (define-public python-pytest-cov supports coverage of subprocesses.") (license license:expat))) +(define-public python-pytest-cov-3.0 + (package + (inherit python-pytest-cov) + (version "3.0.0") + (source + (origin + (method url-fetch) + (uri (pypi-uri "pytest-cov" version)) + (sha256 + (base32 "0w6lfv8gc1lxmnvsz7mq5z9shxac5zz6s9mwrai108kxc6qzbw77")))))) + (define-public python-pytest-httpserver (package (name "python-pytest-httpserver")