mbox series

[bug#60238,0/7] gnu: Add fava.

Message ID 20221221130751.9303-1-i@dan.games
Headers show
Series gnu: Add fava. | expand

Message

dan Dec. 21, 2022, 1:07 p.m. UTC 
This patch series adds fava, a web interface for the double-entry bookkeeping
software Beancount.  Note that the latest version of python-cheroot is 9.0.0,
but the latest release of fava depends on python-cheroot lower than 9.  Thus,
we have to pack 8.6.0 at the moment.

dan (7):
  gnu: Add python-markdown2.
  gnu: Add python-portend.
  gnu: Add python-inflect.
  gnu: Add python-jaraco-text.
  gnu: Add python-pypytools.
  gnu: Add python-cheroot.
  gnu: Add fava.

 gnu/packages/finance.scm    |  35 ++++++++++++
 gnu/packages/python-web.scm |  29 ++++++++++
 gnu/packages/python-xyz.scm | 106 ++++++++++++++++++++++++++++++++++++
 3 files changed, 170 insertions(+)


base-commit: 7833acab0da02335941974608510c02e2d1d8069

Comments

dan Jan. 15, 2023, 2:37 p.m. UTC | #1 
ping
Ludovic Courtès Jan. 26, 2023, 10:02 a.m. UTC | #2 
Hi dan,

dan <i@dan.games> skribis:

> This patch series adds fava, a web interface for the double-entry bookkeeping
> software Beancount.  Note that the latest version of python-cheroot is 9.0.0,
> but the latest release of fava depends on python-cheroot lower than 9.  Thus,
> we have to pack 8.6.0 at the moment.
>
> dan (7):
>   gnu: Add python-markdown2.
>   gnu: Add python-portend.
>   gnu: Add python-inflect.
>   gnu: Add python-jaraco-text.
>   gnu: Add python-pypytools.
>   gnu: Add python-cheroot.
>   gnu: Add fava.

Overall this looks good to me and to
<https://qa.guix.gnu.org/issue/60238>.

However, most synopses and descriptions would need to be improved a bit,
as per
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>.
(I know, it’s not fun, but it’s helpful for users.)

Could you give it a stab and send a v2?

Thanks in advance and sorry for the delay!

Ludo’.
Sharlatan Hellseher March 17, 2024, 5:07 p.m. UTC | #3 
Hi dan,

I've completed the other round of review and applied some modification
to the patches. Some of them were already applied or available on the
time I check the series.

- New packages [4/4]
  - [X] fava
    - Update to 1.24.4, the highest compatible with available Flask in Guix.
    - Fix tests
    - Relax requirements
  - [X] python-cheroot
    - Update to 10.0.1
    - Enable tests
  - [X] python-markdown2
    - Update to 2.4.13
    - Enable tests
    - Improve description
  - [X] python-pypytools
- Related fixes to make series buildable [1/1]
  - [X] beancount
    - Adjust package style
    - Enable tests
    - Enable sanity check

Build and Lint are passed locally for V3, let's check what's QA would
tell us now ;-).

--
Oleg
Sharlatan Hellseher March 19, 2024, 9:50 a.m. UTC | #4 
Hi,

- Already avialalbe packages [3/3]
  - [X] python-jaraco-text :: Added from
    <https://issues.guix.gnu.org/68192>
  - [X] python-inflect :: Added in
    6cac909c95b77b58f48b920e49f8802526a3e290 by Ricardo Wurmus
    <rekado@elephly.net>
  - [X] python-portend :: Added from <https://issues.guix.gnu.org/68191>

Patches adding fava, python-cheroot, python-pypytools and
python-markdown2 are pushed as 228c55cbf0..044d3f4bef to master.

Thanks,
Oleg