[bug#34515,04/13] gnu: python-txamqp: Depend on python-hyperlink.

Message ID ed41233858e6925bf1b824b7b496126f3f4a0906.1550437064.git.leo@famulari.name
State Accepted
Headers show
Series [bug#34515,01/13] gnu: Add python-humanize. | expand

Checks

Context Check Description
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied

Commit Message

Leo Famulari Feb. 17, 2019, 8:57 p.m. UTC
* gnu/packages/python-xyz.scm (python-txamqp,
python2-txamqp)[propagated-inputs]: Add python-hyperlink.
---
 gnu/packages/python-xyz.scm | 1 +
 1 file changed, 1 insertion(+)

Comments

Ricardo Wurmus Feb. 18, 2019, 8:05 a.m. UTC | #1
Leo Famulari <leo@famulari.name> writes:

> * gnu/packages/python-xyz.scm (python-txamqp,
> python2-txamqp)[propagated-inputs]: Add python-hyperlink.
> ---
>  gnu/packages/python-xyz.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 745569c14a..effaea1dcf 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -8158,6 +8158,7 @@ alternative when librabbitmq is not available.")
>      (build-system python-build-system)
>      (propagated-inputs
>       `(("python-six" ,python-six)
> +       ("python-hyperlink" ,python-hyperlink)
>         ("python-twisted" ,python-twisted)))
>      (home-page "https://github.com/txamqp/txamqp")
>      (synopsis "Communicate with AMQP peers and brokers using Twisted")

How can we tell that txamqp really requires hyperlink?  I haven’t been
able to find a reference to hyperlink in the txamqp sources.
Leo Famulari Feb. 19, 2019, 3:22 a.m. UTC | #2
On Mon, Feb 18, 2019 at 09:05:47AM +0100, Ricardo Wurmus wrote:
> Leo Famulari <leo@famulari.name> writes:
> > python2-txamqp)[propagated-inputs]: Add python-hyperlink.
> 
> How can we tell that txamqp really requires hyperlink?  I haven’t been
> able to find a reference to hyperlink in the txamqp sources.

Indeed, it looks like Twisted itself requires hyperlink now. I'll adjust
the rest of the patches accordingly.

Patch

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 745569c14a..effaea1dcf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -8158,6 +8158,7 @@  alternative when librabbitmq is not available.")
     (build-system python-build-system)
     (propagated-inputs
      `(("python-six" ,python-six)
+       ("python-hyperlink" ,python-hyperlink)
        ("python-twisted" ,python-twisted)))
     (home-page "https://github.com/txamqp/txamqp")
     (synopsis "Communicate with AMQP peers and brokers using Twisted")