diff mbox series

[bug#66886,5/5] gnu: python-textual: Update to 0.41.0.

Message ID fdebb08aa00dd993ffb110c68609eacbdcae5811.1698858108.git.goodoldpaul@autistici.org
State New
Headers show
Series [bug#66886,1/5] gnu: Add python-pygments-2.16. | expand

Commit Message

Giacomo Leidi Nov. 1, 2023, 5:01 p.m. UTC 
* gnu/packages/python-xyz.scm (python-textual): Update to 0.41.0;
[source]: switch to git-origin;
[build-system]: switch to pyproject-build-system;
[arguments]<test-flags>: disable failing tests;
<phases>: use check phase from pyproject-build-system and adapt build
machinery to our old version of poetry;
[propagated-inputs]: adapt to pyproject.toml;
[native-inputs] add poetry and python-pytest-asyncio.

Change-Id: I1060b25cb2ec439f26a4348305bc05fd0b09cf07
---
 gnu/packages/python-xyz.scm | 58 ++++++++++++++++++++++---------------
 1 file changed, 34 insertions(+), 24 deletions(-)

Comments

jgart Nov. 2, 2023, 12:14 a.m. UTC | #1 
Hi,

Thanks for sending this patch set. I'll try to review this week(end).

all best,

jgart
Giacomo Leidi Nov. 16, 2023, 11:55 p.m. UTC | #2 
Hi jgart,

On 11/2/23 01:14, jgart wrote:
> Hi,
>
> Thanks for sending this patch set. I'll try to review this week(end).
>
> all best,
>
> jgart

I'm sending an updated patchset rebased on current master.


Thank you for your time,

giacomo
jgart Nov. 18, 2023, 2:44 a.m. UTC | #3 
Hi,

This breaks httpie, did you try building the packages that depend on these updates?
Giacomo Leidi Dec. 3, 2023, 3:21 p.m. UTC | #4 
Hi jgart,

apologies for the delay but I had some problems with my SSD :( .

On 11/18/23 03:44, jgart wrote:
> Hi,
>
> This breaks httpie, did you try building the packages that depend on these updates?

I did not because I often work from a Pinebook and it's quite painful 
building on such hardware, anyway I managed to write a script that 
builds dependents of a package [0], not sure if it may be useful to add 
something like this to the Guix repo (maybe there's already something 
and I just don't know, please correct me if I'm wrong).

I now checked that the following packages do not regress on x86_64:


build-dependents -p python-textual python-mdit-py-plugins python-rich python-markdown-it-py python-jupytext -e python-vaex-core  | grep 'gnu/store' | sort -u
/gnu/store/1qsr70xih21ckd7zn086p0g6qj4w294c-python-pygmsh-7.1.17
/gnu/store/31hjy58nzczfgh2wasx693mn40nk5qsx-python-textual-0.41.0
/gnu/store/3iiy6qpfiqsvxvj3yzwan2412bxk98b0-python-pyvista-0.42.3
/gnu/store/4fjyfday8nghnw76xkyaky5a33f6hfi3-clikan-0.2.1-1.55ab29e
/gnu/store/4vnm5l46k4lwmg3jywlga1cppcm4czkv-pigx-sars-cov-2-0.0.9
/gnu/store/9f734m0c1ik4kwgqvixlnl1jg8qwbdqi-python-mdit-py-plugins-0.4.0
/gnu/store/b3nd3bpmlqwnw8bbgnk8i78hqa5h038w-python-pytorch-lightning-2.0.2
/gnu/store/fkd73cjmmxshdx5cr5zd190igq3l983i-python-scikit-fem-8.1.0
/gnu/store/jcs4prg3x8pzxfznqsw1qbqknjbh4qh3-python-rich-13.7.0
/gnu/store/jyzv1dhh5q0xmy2m4lk5a64br1qpjak0-pigx-0.0.3
/gnu/store/lr7qr3pqfwy7qxnihjz5kjs6gxwp061b-python-pythonanywhere-0.12.1
/gnu/store/lz43xymxhk4gahl3jvgkq6jqpniwayvg-python-markdown-it-py-3.0.0
/gnu/store/mq1sckkxkhz2snij4y46pslr9hmvhl1q-httpie-3.2.1
/gnu/store/nrspad1inl1lx2zmpacyrq5xrad49v1h-python-spacy-3.5.3
/gnu/store/pckjpvdb5n6fc7zbk4bi0dh52ch7i4ky-python-sphinx-theme-builder-0.2.0b1
/gnu/store/rsv5qiy8mj57429pzqhyb8zkgcd0glvw-python-jupytext-1.15.2
/gnu/store/s3acmhslqfw7k44lcbrw2dsr2v7q3346-pelican-4.7.2
/gnu/store/zqg8bfcd2c37yb5nn484hyi46z823krp-python-enoslib-8.0.1


python-vaex-core is also broken on master.


I'm sending an updated patchset rebased on current master.


Thank you for your help :)


giacomo


[0]: 
https://git.sr.ht/~fishinthecalculator/guix-dev-tools/tree/main/item/src/build-dependents
Giacomo Leidi Dec. 29, 2023, 10:07 p.m. UTC | #5 
Hi,

this is a friendly ping :)

Thank you for your time!
Giacomo Leidi Jan. 14, 2024, 11:54 p.m. UTC | #6 
Hi!

This is a friendly ping :) I'm sending an updated patchset, I built the 
following store paths on x86_64 to make sure there are no regressions:

/gnu/store/5mh7vxaaclnh11aprsql6b40hgickmjc-python-sphinx-theme-builder-0.2.0b1
/gnu/store/v12ns2lbyr2a4iagyvjzgala1p4g2qx8-python-cplot-0.9.3
/gnu/store/b9fb35pg45gxd8chzsawk1qddsyqfkh9-python-mdit-py-plugins-0.4.0
/gnu/store/fp1y833b7k02x0fbrf8304clwx1abykq-python-pyvista-0.42.3
/gnu/store/ymiq9p2zy0agam64qaczwh4bflcfbwp5-python-pytorch-lightning-2.0.2
/gnu/store/qx17ipkk3zfhb3p58vbxia5jfcwy012a-python-vaex-core-4.13.0
/gnu/store/lxj3wfcg5nd35fja437qi80njpvaszl1-python-enoslib-8.0.1
/gnu/store/pgbjawlsb3liw9b09ncdilnbaymj97l5-trinityrnaseq-2.13.2
/gnu/store/zb004yxxff9104wlvqp4f3iswrhrfxq9-pelican-4.7.2
/gnu/store/9rrdfiarnv0i48ql0fn7baqd7rl2chyd-clikan-0.2.1-1.55ab29e
/gnu/store/imdaffwaxn17x4z4nii0j1361g16sp4x-python-markdown-it-py-3.0.0
/gnu/store/wjjsa5gnni4xhjv0pyrp0whxmhkcs8lc-python-jupytext-1.15.2
/gnu/store/wjjsa5gnni4xhjv0pyrp0whxmhkcs8lc-python-jupytext-1.15.2
/gnu/store/by20s2xdvavjcgljqpmp37slx4dvcn9p-pigx-sars-cov-2-0.0.9
/gnu/store/2f5h7ahyqkr0mrs2k4lkrflvaazcdvw8-httpie-3.2.1
/gnu/store/gkardnjhnddxdxhkabxxvi5qc3rbx42f-python-textual-0.47.1
/gnu/store/61gbzbgdp3xj9p8bg1z70mlmidjfw0zq-python-spacy-3.5.3
/gnu/store/fpvw7hb32n1xqxa7w4m18n7hr9d2v76g-python-pytest-cookies-0.7.0
/gnu/store/9bhr9dvfsvp4xl9xgbgkl3dgd5bj7nzf-python-quadpy-0.16.10
/gnu/store/pzf3nkc8gsdd0ckqsw8aa5br47yqkp3j-python-pygmsh-7.1.17
/gnu/store/hkpdwjspwhgc568yp543pgy4sck9f733-python-rich-13.7.0
/gnu/store/b3y6nzc1aswq45y3kk72dza6fk9nxi92-python-pythonanywhere-0.12.1
/gnu/store/lj8x1sfyzlqcsw9ml71368dqa3zzpcy5-pigx-0.0.3
/gnu/store/gkardnjhnddxdxhkabxxvi5qc3rbx42f-python-textual-0.47.1


Thank you for your time,


giacomo
Giacomo Leidi Feb. 27, 2024, 6:42 p.m. UTC | #7 
Hi everyone, closing since this has been superseded by 66886 .
Giacomo Leidi Feb. 27, 2024, 6:42 p.m. UTC | #8 
I meant https://issues.guix.gnu.org/68207 :)

On 2/27/24 19:42, paul wrote:
> Hi everyone, closing since this has been superseded by 66886 .
>
diff mbox series

Patch

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index e7889029f3..696790e4a1 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -18216,20 +18216,8 @@  (define-public python-rich-click
 (define-public python-textual
   (package
     (name "python-textual")
-    (version "0.1.18")
+    (version "0.41.0")
     (source (origin
-              (method url-fetch)
-              (uri (pypi-uri "textual" version))
-              (sha256
-               (base32
-                "08yg5a51hz1axfj5hx28hx31gq5apcj6vpkkmawmiplisa73z25j"))))
-    (build-system python-build-system)
-    (arguments
-     (let ((tests
-            ;; The release on pypi comes without tests.  We can't build
-            ;; from this checkout, though, because installation requires
-            ;; an invocation of poetry.
-            (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/Textualize/textual")
@@ -18237,19 +18225,41 @@  (define-public python-textual
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0b3ycwqhp21mg9fvmadgxhgbvkwq6fd784l2xcmvy77rravrnnax")))))
-       (list #:phases
-             #~(modify-phases %standard-phases
-                 (replace 'check
-                   (lambda* (#:key tests? #:allow-other-keys)
-                     (when tests?
-                       (copy-recursively #$(file-append tests "/tests")
-                                         "tests")
-                       (invoke "python" "-m" "pytest" "-vv"))))))))
+                "0fmximmnxb7h7swdrs0amlya09h0yyr1h1k09za7isihb40njwib"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      ;; 3 failed, 1932 passed, 1 skipped, 4 xfailed, 10 warnings in 115.19s (0:01:55)
+      #:test-flags
+      #~'("-k"
+          ;; this test fails because of an AssertionError:
+          ;; assert app.devtools is not None
+          #$(string-append "not test_textual_env_var"
+                           ;; these tests require python-tresitter-languages
+                           " and not test_register_language"
+                           " and not test_register_language_existing_language"))
+      #:phases #~(modify-phases %standard-phases
+                   ;; TODO: This is because of our old version of poetry.
+                   ;; It can be removed once it's been updated to a current one.
+                   (add-after 'unpack 'adapt-pyproject.toml
+                     (lambda _
+                       (substitute* "pyproject.toml"
+                         (("group\\.dev\\.") "dev-"))))
+                   ;; snapshot tests require syrupy
+                   (add-after 'adapt-pyproject.toml 'remove-snapshot-tests
+                     (lambda _
+                       (delete-file "tests/snapshot_tests/test_snapshots.py"))))))
     (propagated-inputs
-     (list python-rich python-typing-extensions))
+     (list python-importlib-metadata
+           python-linkify-it-py
+           python-markdown-it-py
+           python-mdit-py-plugins
+           python-rich
+           python-typing-extensions))
     (native-inputs
-     (list python-pytest))
+     (list poetry
+           python-pytest
+           python-pytest-asyncio))
     (home-page "https://github.com/Textualize/textual")
     (synopsis "Build text user interfaces in Python")
     (description "Textual is a @acronym{TUI, Text User Interface} framework