| Message ID | f733b976e1cf78b3d2a80eea904ab7fa5a2c6df4.1624269361.git.public@yoctocell.xyz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add ocamlformat and dependencies | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
Le Mon, 21 Jun 2021 12:01:53 +0200, Xinglu Chen <public@yoctocell.xyz> a écrit : > * gnu/packages/ocaml.scm (ocaml-menhir-sdk): New variable. > --- > gnu/packages/ocaml.scm | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm > index 08406a206d..d7d3afd36c 100644 > --- a/gnu/packages/ocaml.scm > +++ b/gnu/packages/ocaml.scm > @@ -1069,6 +1069,19 @@ Knuth’s LR(1) parser construction technique.") > (description "This package provides a runtime support library > for parsers generated by Menhir."))) > > +(define-public ocaml-menhir-sdk > + (package > + (inherit ocaml-menhir) > + (name "ocaml-menhir-sdk") > + (arguments > + '(#:package "menhirSdk" > + #:test-target "sdk")) > + (properties > + `((upstream-name . "menhirSdk"))) > + (synopsis "Compile-time library for auxiliary tools related to > Menhir") > + (description "This package provides a compile-time library for > auxiliary +tools related to Menhir."))) > + > (define-public ocaml-bigarray-compat > (package > (name "ocaml-bigarray-compat") MenhirLib and MenhirSdk are both already part of the ocaml-menhir package, so I don't think it is useful to add separate packages for them. WDYT?
On Sun, Jun 27 2021, Julien Lepiller wrote: > Le Mon, 21 Jun 2021 12:01:53 +0200, > Xinglu Chen <public@yoctocell.xyz> a écrit : > >> * gnu/packages/ocaml.scm (ocaml-menhir-sdk): New variable. >> --- >> gnu/packages/ocaml.scm | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm >> index 08406a206d..d7d3afd36c 100644 >> --- a/gnu/packages/ocaml.scm >> +++ b/gnu/packages/ocaml.scm >> @@ -1069,6 +1069,19 @@ Knuth’s LR(1) parser construction technique.") >> (description "This package provides a runtime support library >> for parsers generated by Menhir."))) >> >> +(define-public ocaml-menhir-sdk >> + (package >> + (inherit ocaml-menhir) >> + (name "ocaml-menhir-sdk") >> + (arguments >> + '(#:package "menhirSdk" >> + #:test-target "sdk")) >> + (properties >> + `((upstream-name . "menhirSdk"))) >> + (synopsis "Compile-time library for auxiliary tools related to >> Menhir") >> + (description "This package provides a compile-time library for >> auxiliary +tools related to Menhir."))) >> + >> (define-public ocaml-bigarray-compat >> (package >> (name "ocaml-bigarray-compat") > > MenhirLib and MenhirSdk are both already part of the ocaml-menhir > package, so I don't think it is useful to add separate packages for > them. WDYT? Ah, then we can probably drop them, but they (Menhir, MenhirLib, and MenhirSdk) are three separate packages on Opam, so i could also make sense to restrict ‘ocaml-menhir’ to only the Menhir package. WDYT?
On Sun, Jun 27 2021, Xinglu Chen wrote: > On Sun, Jun 27 2021, Julien Lepiller wrote: > >> Le Mon, 21 Jun 2021 12:01:53 +0200, >> Xinglu Chen <public@yoctocell.xyz> a écrit : >> >>> * gnu/packages/ocaml.scm (ocaml-menhir-sdk): New variable. >>> --- >>> gnu/packages/ocaml.scm | 13 +++++++++++++ >>> 1 file changed, 13 insertions(+) >>> >>> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm >>> index 08406a206d..d7d3afd36c 100644 >>> --- a/gnu/packages/ocaml.scm >>> +++ b/gnu/packages/ocaml.scm >>> @@ -1069,6 +1069,19 @@ Knuth’s LR(1) parser construction technique.") >>> (description "This package provides a runtime support library >>> for parsers generated by Menhir."))) >>> >>> +(define-public ocaml-menhir-sdk >>> + (package >>> + (inherit ocaml-menhir) >>> + (name "ocaml-menhir-sdk") >>> + (arguments >>> + '(#:package "menhirSdk" >>> + #:test-target "sdk")) >>> + (properties >>> + `((upstream-name . "menhirSdk"))) >>> + (synopsis "Compile-time library for auxiliary tools related to >>> Menhir") >>> + (description "This package provides a compile-time library for >>> auxiliary +tools related to Menhir."))) >>> + >>> (define-public ocaml-bigarray-compat >>> (package >>> (name "ocaml-bigarray-compat") >> >> MenhirLib and MenhirSdk are both already part of the ocaml-menhir >> package, so I don't think it is useful to add separate packages for >> them. WDYT? > > Ah, then we can probably drop them, but they (Menhir, MenhirLib, and > MenhirSdk) are three separate packages on Opam, so i could also make > sense to restrict ‘ocaml-menhir’ to only the Menhir package. > > WDYT? Ping! :)
diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index 08406a206d..d7d3afd36c 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -1069,6 +1069,19 @@ Knuth’s LR(1) parser construction technique.") (description "This package provides a runtime support library for parsers generated by Menhir."))) +(define-public ocaml-menhir-sdk + (package + (inherit ocaml-menhir) + (name "ocaml-menhir-sdk") + (arguments + '(#:package "menhirSdk" + #:test-target "sdk")) + (properties + `((upstream-name . "menhirSdk"))) + (synopsis "Compile-time library for auxiliary tools related to Menhir") + (description "This package provides a compile-time library for auxiliary +tools related to Menhir."))) + (define-public ocaml-bigarray-compat (package (name "ocaml-bigarray-compat")