diff mbox series

[bug#55494] daemon: runChild() is forbidden to talk during environment set up

Message ID ea-mime-62840ee6-4587-244ac94a@www-8.mailo.com
State Accepted
Headers show
Series [bug#55494] daemon: runChild() is forbidden to talk during environment set up | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

yarl baudig May 17, 2022, 9:08 p.m. UTC 
DerivationGoal::startBuilder() is waiting for an empty line as a check that
the environment set up is fine.

Fixes <https://issues.guix.gnu.org/55324>
---
 nix/libstore/build.cc | 1 -
 1 file changed, 1 deletion(-)

Comments

Ludovic Courtès May 19, 2022, 2:48 p.m. UTC | #1 
Hi,

yarl-baudig@mailoo.org skribis:

> DerivationGoal::startBuilder() is waiting for an empty line as a check that
> the environment set up is fine.
>
> Fixes <https://issues.guix.gnu.org/55324>

Oh, good catch!

I tweaked the commit log and applied it.

Thank you!

Ludo’.
diff mbox series

Patch

diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
index f6431bb726..9305208009 100644
--- a/nix/libstore/build.cc
+++ b/nix/libstore/build.cc
@@ -2057,7 +2057,6 @@  void DerivationGoal::runChild()
                 Path source = i->second;
                 Path target = chrootRootDir + i->first;
                 if (source == "/proc") continue; // backwards compatibility
-                debug(format("bind mounting `%1%' to `%2%'") % source % target);
                 if (stat(source.c_str(), &st) == -1)
                     throw SysError(format("getting attributes of path `%1%'") % source);
                 if (S_ISDIR(st.st_mode))