From patchwork Tue May 17 21:08:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yarl baudig X-Patchwork-Id: 39462 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9322127BBEA; Wed, 18 May 2022 13:10:57 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5C03A27BBE9 for ; Wed, 18 May 2022 13:10:57 +0100 (BST) Received: from localhost ([::1]:46626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrIW0-0003Ck-IV for patchwork@mira.cbaines.net; Wed, 18 May 2022 08:10:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrCCB-0001C5-HW for guix-patches@gnu.org; Wed, 18 May 2022 01:26:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrCCA-0006Ao-T5 for guix-patches@gnu.org; Wed, 18 May 2022 01:26:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nrCCA-0007rx-M0 for guix-patches@gnu.org; Wed, 18 May 2022 01:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55494] [PATCH] daemon: runChild() is forbidden to talk during environment set up Resent-From: yarl-baudig@mailoo.org Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 May 2022 05:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55494@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165285154030215 (code B ref -1); Wed, 18 May 2022 05:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 May 2022 05:25:40 +0000 Received: from localhost ([127.0.0.1]:58616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrCBn-0007rG-BL for submit@debbugs.gnu.org; Wed, 18 May 2022 01:25:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:37422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nr4RF-0001Gg-To for submit@debbugs.gnu.org; Tue, 17 May 2022 17:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nr4RF-0005GW-PP for guix-patches@gnu.org; Tue, 17 May 2022 17:09:05 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:57700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nr4RB-0004bp-Lz for guix-patches@gnu.org; Tue, 17 May 2022 17:09:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1652821734; bh=UDTdCZ/JLnra28tEhnzcUImCT5fI0ciK/PojSsDI5WQ=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: Content-Type:Content-Transfer-Encoding; b=Xqmx7l9xtoNsYG8hMwEs2XOqmaGrg8zMO6XYinDcCBlJw5ufMJSXxPWrRJTJ2giDy nA47aDTMO7GI7LZCK+51Pc1VV4EEWjs3jyhpY4gGe/nD0NApc0bz/x8HfteoPpJUTK xP5hLqrGyeR/a6CxBEMavtzPm1QUN/B2PtlIq7Qs= Received: by www-8.mailo.com with http webmail; Tue, 17 May 2022 23:08:54 +0200 (CEST) X-EA-Auth: pCR45ckgEngT0vLeTYptdKcdUQKJq5J03AVm8V/n0EjhgB3fQBCh1YnGwobmc5wKgmnFwbvSdWyPs2cNWlVAZurz13FNyFLK From: yarl-baudig@mailoo.org Date: Tue, 17 May 2022 23:08:54 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: Received-SPF: pass client-ip=213.182.54.11; envelope-from=yarl-baudig@mailoo.org; helo=msg-1.mailo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 18 May 2022 01:25:37 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Wed, 18 May 2022 08:10:42 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches DerivationGoal::startBuilder() is waiting for an empty line as a check that the environment set up is fine. Fixes --- nix/libstore/build.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc index f6431bb726..9305208009 100644 --- a/nix/libstore/build.cc +++ b/nix/libstore/build.cc @@ -2057,7 +2057,6 @@ void DerivationGoal::runChild() Path source = i->second; Path target = chrootRootDir + i->first; if (source == "/proc") continue; // backwards compatibility - debug(format("bind mounting `%1%' to `%2%'") % source % target); if (stat(source.c_str(), &st) == -1) throw SysError(format("getting attributes of path `%1%'") % source); if (S_ISDIR(st.st_mode))