mbox

[bug#43915,0/3] Update python-breathe and dependencies

Message ID cover.1602367454.git.simon@simonsouth.net
Headers show

Message

Simon South Oct. 10, 2020, 10:21 p.m. UTC 
These patches update the python-breathe package and two of its
dependencies, python-sphinx and python-six, to their latest available
version. (python-docutils is already up-to-date.)

Note "guix refresh --list-dependent" reports that python-breathe,
python-sphinx and python-six have 1, 363 and 6,538 dependent packages,
respectively.

--
Simon South
simon@simonsouth.net


Simon South (3):
  gnu: python-six: Update to 1.15.0.
  gnu: python-sphinx: Update to 3.2.1.
  gnu: python-breathe: Update to 4.22.1.

 gnu/packages/python-xyz.scm | 4 ++--
 gnu/packages/sphinx.scm     | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Simon South Oct. 10, 2020, 10:28 p.m. UTC | #1 
Simon South <simon@simonsouth.net> writes:
> Note "guix refresh --list-dependent" reports that python-breathe,
> python-sphinx and python-six have 1, 363 and 6,538 dependent packages,
> respectively.

...and as soon as I hit "send" I notice this in the Guix manual:

    ...if your patch is to be applied on a branch other than ‘master’,
    say ‘core-updates’, specify it in the subject like ‘[PATCH
    core-updates] ...’.

I can resend if desired, and I'll follow this convention in the future.
Christopher Baines Oct. 23, 2020, 9:48 p.m. UTC | #2 
Simon South <simon@simonsouth.net> writes:

> Simon South <simon@simonsouth.net> writes:
>> Note "guix refresh --list-dependent" reports that python-breathe,
>> python-sphinx and python-six have 1, 363 and 6,538 dependent packages,
>> respectively.
>
> ...and as soon as I hit "send" I notice this in the Guix manual:
>
>     ...if your patch is to be applied on a branch other than ‘master’,
>     say ‘core-updates’, specify it in the subject like ‘[PATCH
>     core-updates] ...’.
>
> I can resend if desired, and I'll follow this convention in the future.

No problem :)

I've pushed the python-six change to the core-updates branch as
6f95911ad175a836fbd5aaa42a8aecb0fc335a1e.

Given the python-sphinx change is a major version update, I was unsure
about pushing it to master, at least without testing whether any of the
363 dependent packages are broken by this change.

I think the staging branch is also frozen. I'll investigate tomorrow
about starting a new staging branch...
Simon South Oct. 23, 2020, 10:39 p.m. UTC | #3 
Christopher Baines <mail@cbaines.net> writes:
> I've pushed the python-six change to the core-updates branch as
> 6f95911ad175a836fbd5aaa42a8aecb0fc335a1e.

Nice, thanks.

> Given the python-sphinx change is a major version update, I was unsure
> about pushing it to master, at least without testing whether any of
> the 363 dependent packages are broken by this change.

Yes, after submitting the patch I realized: It's really too significant
a change for the amount of testing I've done on it. Better to hold off
for now I think, especially with the release coming up.

My interest really was in seeing python-breathe updated, as the new
version happens to fix a warning from Sphinx when generating Texinfo
output (and there's only one other package it affects, which I
definitely have tested). I thought updating its dependencies at the same
time would be a good idea but now I think it would be a bit reckless.
Christopher Baines Oct. 24, 2020, 8:17 p.m. UTC | #4 
Simon South <simon@simonsouth.net> writes:

> Christopher Baines <mail@cbaines.net> writes:
>> Given the python-sphinx change is a major version update, I was unsure
>> about pushing it to master, at least without testing whether any of
>> the 363 dependent packages are broken by this change.
>
> Yes, after submitting the patch I realized: It's really too significant
> a change for the amount of testing I've done on it. Better to hold off
> for now I think, especially with the release coming up.
>
> My interest really was in seeing python-breathe updated, as the new
> version happens to fix a warning from Sphinx when generating Texinfo
> output (and there's only one other package it affects, which I
> definitely have tested). I thought updating its dependencies at the same
> time would be a good idea but now I think it would be a bit reckless.

I've gone ahead and created a staging-next branch with the python-sphinx
and python-breathe patches now.

I'll leave it up to you whether to close this bug, or leave it open
until the staging-next branch is merged.