mbox

[bug#43823,v2,0/3] Knot: Enable DoH; build Info Manual; work on aarch64-linux

Message ID cover.1601991615.git.simon@simonsouth.net
Headers show

Message

Simon South Oct. 6, 2020, 1:56 p.m. UTC 
This updated set of patches incorporates feedback from Tobias
Geerinckx-Rice (thank you!) and improves on the original by

- Using input packages' own name as their label;

- Removing mention in the commit descriptions of silencing warnings
  from configure (he's right, it's a bit silly to worry about this);

- Replacing the description in the patch file with something more
  informative that includes a link to the original issue; and

- Registering the patch file in gnu/local.mk.

For convenience, here's my original cover letter:

These changes to the Knot package complement work done today by
Tobias[0] by silencing the remaining warnings from configure while
adding a bit of new functionality. The patches

- Enable DNS-over-HTTPS support in the kdig utility, by adding the
  nghttp2 library as a native [actually regular] input;

- Cause the Info manual to be built and included in the output; and

- Fix a test[1] that prevented the package from building on
  aarch64-linux systems.

[0] Now that everyone's finished building commit 2eb0585.
[1] See https://gitlab.nic.cz/knot/knot-dns/-/issues/693

--
Simon South
simon@simonsouth.net


Simon South (3):
  gnu: knot: Enable DNS-over-HTTPS support in kdig.
  gnu: knot: Build the Info manual.
  gnu: knot: Fix test failure on aarch64-linux.

 gnu/local.mk                                  |  1 +
 gnu/packages/dns.scm                          | 16 ++++++++++++++--
 ...est_net_shortwrite-ensure-connection.patch | 19 +++++++++++++++++++
 3 files changed, 34 insertions(+), 2 deletions(-)
 create mode 100644 gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch

Comments

Tobias Geerinckx-Rice Oct. 6, 2020, 2:41 p.m. UTC | #1 
Simon,

Thank you for this series.  I really like the way our Knot package 
looks now.

Pushed to master as 4e869b180a94aa5bf5ae70ca48e0527e8e8db8db 
together with XDP support, and some insignificant changes:

Simon South 写道：
> - Removing mention in the commit descriptions of silencing 
> warnings
>   from configure (he's right, it's a bit silly to worry about 
>   this);

These warnings weren't worth it but it's certainly not silly to 
pay attention to ./configure output.  Good habit.  ./configure 
can't know if we're regressing, after all.

> - Replacing the description in the patch file with something 
> more
>   informative that includes a link to the original issue; and

Thanks.

> - Registering the patch file in gnu/local.mk.

Perfect.  I added ‘(dist_patch_DATA)’ to the commit message.

Closing,

T G-R
Tobias Geerinckx-Rice Oct. 6, 2020, 2:49 p.m. UTC | #2 
Tobias Geerinckx-Rice via Guix-patches via 写道：
> Pushed to master as 4e869b180a94aa5bf5ae70ca48e0527e8e8db8db 
> together
> with XDP support, and some insignificant changes:

Oh, and of course a copyright line for you in (gnu packages dns).

Kind regards,

T G-R