diff mbox series

[bug#63314,2/2] services: elogind: Add elogind as a shepherd PAM requirement.

Message ID c7ac9075e4ac9e8854d449bcc6e15a2f1fdd5201.1683308811.git.dev@jpoiret.xyz
State New
Headers
Series Add PAM shepherd requirements |

Commit Message

Josselin Poiret May 5, 2023, 5:51 p.m. UTC 
From: Josselin Poiret <dev@jpoiret.xyz>

* gnu/services/desktop.scm (pam-extension-procedure): Add the elogind shepherd
requirement to the PAM extender.
---
 gnu/services/desktop.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ludovic Courtès May 8, 2023, 9:46 a.m. UTC | #1 
Josselin Poiret <dev@jpoiret.xyz> skribis:

> From: Josselin Poiret <dev@jpoiret.xyz>
>
> * gnu/services/desktop.scm (pam-extension-procedure): Add the elogind shepherd
> requirement to the PAM extender.
> ---
>  gnu/services/desktop.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index 3adcfe8e5d..d62536a27e 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -1192,7 +1192,8 @@ (define (pam-extension-procedure config)
>            (lambda (pam)
>              (pam-service
>               (inherit pam)
> -             (session (cons pam-elogind (pam-service-session pam)))))))))
> +             (session (cons pam-elogind (pam-service-session pam))))))
> +         (shepherd-requirements '(elogind)))))

LGTM.

Should we add a greetd system test that catches the bug?

Ludo’.
diff mbox series

Patch

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 3adcfe8e5d..d62536a27e 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1192,7 +1192,8 @@  (define (pam-extension-procedure config)
           (lambda (pam)
             (pam-service
              (inherit pam)
-             (session (cons pam-elogind (pam-service-session pam)))))))))
+             (session (cons pam-elogind (pam-service-session pam))))))
+         (shepherd-requirements '(elogind)))))
 
 (define (elogind-shepherd-service config)
   "Return a Shepherd service to start elogind according to @var{config}."