diff mbox series

[bug#45062,1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection.

Message ID TYAP286MB018505ABD00FEB55EB99B34AA3CE0@TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM
State Accepted
Headers show
Series [bug#45062,1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. | expand

Commit Message

宋文武 Dec. 7, 2020, 11:21 a.m. UTC 
Kei Kebreau <kkebreau@posteo.net> writes:

> Installing both 'xfce4-panel' and 'xfce4-whiskermenu-plugin' into the
> user profile does work!
Okay, but I guess that will be some problem too, since then
X_XFCE4_LIB_DIRS would contain both system and user paths...

> Is there a way to make clear to users and
> administrators that xfce4-panel and its plugins should both be
> installed at the user or system level to ensure proper function?  I
> don't think it's obvious since our Xfce desktop service implicitly
> installs the xfce4-panel.

Yes, how about document it like this:
BTW, your second patch for xfce4-whiskermenu-plugin LGTM, please push.

Thank you!

Comments

Kei Kebreau Dec. 7, 2020, 9:17 p.m. UTC | #1 
I've edited your documentation patch a little bit and pushed it to
master along with my second patch.  Thanks for your input and patch!

Kei

On Mon, 07 Dec 2020 19:21:51 +0800
宋文武 <iyzsong@outlook.com> wrote:

> Kei Kebreau <kkebreau@posteo.net> writes:
> 
> > Installing both 'xfce4-panel' and 'xfce4-whiskermenu-plugin' into
> > the user profile does work!  
> Okay, but I guess that will be some problem too, since then
> X_XFCE4_LIB_DIRS would contain both system and user paths...
> 
> > Is there a way to make clear to users and
> > administrators that xfce4-panel and its plugins should both be
> > installed at the user or system level to ensure proper function?  I
> > don't think it's obvious since our Xfce desktop service implicitly
> > installs the xfce4-panel.  
> 
> Yes, how about document it like this:
>
diff mbox series

Patch

From 75fdb19ea4f68d7e8af899ef4611d269d4821f29 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
Date: Mon, 7 Dec 2020 19:11:03 +0800
Subject: [PATCH] doc: Document about xfce4-panel plugins.

* doc/guix.texi (Desktop Services): Document that xfce4-panel plugin packages
should be added to the 'packages' field of OS.
---
 doc/guix.texi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index a21c4d614e..5eb5b47e14 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -18563,6 +18563,12 @@  This service adds the @code{xfce} package to the system profile, and
 extends polkit with the ability for @code{thunar} to manipulate the file
 system as root from within a user session, after the user has authenticated
 with the administrator's password.
+
+Note that @code{xfce4-panel} and its plugin packages should in the same
+profile to ensure compatibility, when use this @code{xfce} service, you
+should add extra plugins (xfce4-whiskermenu-plugin,
+xfce4-weather-plugin, etc.) to the @code{packages} field of your
+@code{operating-system}.
 @end defvr
 
 @deftp {Data Type} xfce-desktop-configuration
-- 
2.29.2