From patchwork Mon Dec 7 11:21:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5a6L5paH5q2m?= X-Patchwork-Id: 25627 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 99A3727BC01; Mon, 7 Dec 2020 11:23:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id B34EA27BC00 for ; Mon, 7 Dec 2020 11:23:13 +0000 (GMT) Received: from localhost ([::1]:51248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmEbo-0003lP-QX for patchwork@mira.cbaines.net; Mon, 07 Dec 2020 06:23:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmEam-0003k0-G7 for guix-patches@gnu.org; Mon, 07 Dec 2020 06:22:10 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmEaf-00045P-Q5 for guix-patches@gnu.org; Mon, 07 Dec 2020 06:22:08 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmEaf-0001Is-MP for guix-patches@gnu.org; Mon, 07 Dec 2020 06:22:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. Resent-From: =?utf-8?b?5a6L5paH5q2m?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Dec 2020 11:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45062 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kei Kebreau Cc: 45062@debbugs.gnu.org Received: via spool by 45062-submit@debbugs.gnu.org id=B45062.16073401044987 (code B ref 45062); Mon, 07 Dec 2020 11:22:01 +0000 Received: (at 45062) by debbugs.gnu.org; 7 Dec 2020 11:21:44 +0000 Received: from localhost ([127.0.0.1]:52633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmEaE-0001IA-0Q for submit@debbugs.gnu.org; Mon, 07 Dec 2020 06:21:44 -0500 Received: from mail-oln040092255094.outbound.protection.outlook.com ([40.92.255.94]:31711 helo=APC01-HK2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmEaB-0001Hv-Gs for 45062@debbugs.gnu.org; Mon, 07 Dec 2020 06:21:32 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HMt9XOTyJr2CyGrcJUswBziObZI21H5J1BMCblD9DCyn4/qnbV19UEkqbI2QGfRtbnauTAtScmUDFgnyRKYIR8uC1yZ1hR5Fiz/m2bpx7po/jnDaogNBZdM5ZnOF4OEpFCjgLAtzJ2OzHbgyginz/zi6nbFZW9EJGNYfy1+dvrYR/yQPbgvhbXABoiUameHoCa8Aqi0f6erysIXfBcKgZVepVviz5fU4KeTbuoPFzjw0kMe9UkSJFtCA4STEsFfvdHWUA6VU0RbRvtC4DzywKKIaAvzUdSeF9JSuqLQ/NwXp6y8By8ISsovxpSzjE0wNSBZuaM14GX3OpNHMj4Xsfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DDrQ3to6NKnWYcSCp473N8gE5fSkgUOU+600zjbygjE=; b=di3zwxwZQM2SKaXdBSzdRkVDlrtdi9tYXm+4Ir+hQ6R/f4yHaWRPfCr08+DMct3zIqEVako8O5D2C972dj5OnQBpnyPPSaF1aHAZfjLOxch2xA/Jvb/5VINiSqyL7c215t028lL9/7JTxGZEH0XjbccfCS2mE0sC7zYAULULBknAsgym/f+x1/MK69UUv4ZXdsn5oXrFoZjVer2HEDdx/JASKafuBwH7YiOClB60vq6KFi8uQ3jJy09slmKJWGS9h24KzdfUbB3GgsSZPa2VGd67hiPHxZLtLBwhhl5GjrAETct1xS5cjrkJTuO/jE1VYgWV87/U0Z++OcbizCZUMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DDrQ3to6NKnWYcSCp473N8gE5fSkgUOU+600zjbygjE=; b=tLd2P/E7HHUJTAvjBqrNlDXWYCIap0PG8DkPIdeChBkDnHK5dn+WV4M06GsttzfrUOJnEkJEUS0sOtK5mAFKIerbsrRPg8vmTTRT3+JTnoMWCoNOUaCtdjmh8flmxwbSnvtoImvPgNDaWqWZrVihSeoiu/FWnBFYREkFRN8zay9Be5NgK8+hiNL/IwbVCY848il09/Q89FGUwJdf2QojBpAJRSXGTRRc0HrZk15wemJJyVFW2sPPoH4sx/TNTbb7CU3mjX4EDkuYq0hYXmJLtSP6JYUz63pTc09EQFk4jXMaJagYG/YncNBFBumjvRCpR49WhawYS6k0JP2yd0rJCg== Received: from HK2APC01FT064.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::42) by HK2APC01HT121.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::409) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Mon, 7 Dec 2020 11:21:19 +0000 Received: from TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM (2a01:111:e400:7ebc::53) by HK2APC01FT064.mail.protection.outlook.com (2a01:111:e400:7ebc::364) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Mon, 7 Dec 2020 11:21:19 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:7ADD4D7B910CBE1396D27EE326E3F0D6594552698E577FD99648D537CA58296F; UpperCasedChecksum:4D9EF2DB74C39A17F1B694C23E178B080FE470FCA13CF531BEC27E6AEE0BE024; SizeAsReceived:7649; Count:46 Received: from TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM ([fe80::d802:80c9:f6bd:1fbb]) by TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM ([fe80::d802:80c9:f6bd:1fbb%8]) with mapi id 15.20.3632.017; Mon, 7 Dec 2020 11:21:19 +0000 From: =?utf-8?b?5a6L5paH5q2m?= References: <20201206050224.5355-1-kkebreau@posteo.net> <20201206145552.0cfe74d9@posteo.net> Date: Mon, 07 Dec 2020 19:21:51 +0800 In-Reply-To: <20201206145552.0cfe74d9@posteo.net> (Kei Kebreau's message of "Sun, 6 Dec 2020 14:55:52 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) X-TMN: [2ysjdbDxLJczBxa7rnqyL88ypk+GgpbXGhmWyQmUt/9/SNkdwGkP3TOZqfSRz3bt] X-ClientProxiedBy: BYAPR01CA0008.prod.exchangelabs.com (2603:10b6:a02:80::21) To TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8038::14) X-Microsoft-Original-Message-ID: <87im9dyi7k.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (2409:8a62:372:3600:2f1:f5ff:fe18:6bb) by BYAPR01CA0008.prod.exchangelabs.com (2603:10b6:a02:80::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Mon, 7 Dec 2020 11:21:17 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: f6ca8038-5512-44f6-967f-08d89aa23812 X-MS-TrafficTypeDiagnostic: HK2APC01HT121: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /U9NYUSk7UROGadiVS/WzJc6fxfGvNTzoeN3dPUyJ6ykGXMTr+F2EQ8rbrR4MK2qabqO+eFDwLWCUebL5ZExPEWORJE1PS3jUaGDG238hiaki8W7q0rlLuWC5HqrRhVOVikW5TWAL4qeJ02wDauIvfT2fYg3tiHypVGzVdyEV7dV+74AXFo87Wg5quTqCaWL8PQ3jHXDGCjX5Lv7QeWXqQ== X-MS-Exchange-AntiSpam-MessageData: VoCjpmVqFT+FZove5Ag5C9gEVFSm5C34FHIg6chVeAcT6bBypW+NqwyGFUpOG5LXUyPcFylO0LgSmJLxyxjGBUcsAGf9fkocadJIXsh7Fa1drfhGd9ObVB2fwywcX1XK/jpOMX+Kb2mqTTHkjqHrx3tTQGAYXp8D1zxeEdVr83QgsqD4gRa2R3Z5JuTFZIziffnsc326I2NetE4Mpqjyyw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6ca8038-5512-44f6-967f-08d89aa23812 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2020 11:21:19.1516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HK2APC01FT064.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT121 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Kei Kebreau writes: > Installing both 'xfce4-panel' and 'xfce4-whiskermenu-plugin' into the > user profile does work! Okay, but I guess that will be some problem too, since then X_XFCE4_LIB_DIRS would contain both system and user paths... > Is there a way to make clear to users and > administrators that xfce4-panel and its plugins should both be > installed at the user or system level to ensure proper function? I > don't think it's obvious since our Xfce desktop service implicitly > installs the xfce4-panel. Yes, how about document it like this: BTW, your second patch for xfce4-whiskermenu-plugin LGTM, please push. Thank you! From 75fdb19ea4f68d7e8af899ef4611d269d4821f29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Date: Mon, 7 Dec 2020 19:11:03 +0800 Subject: [PATCH] doc: Document about xfce4-panel plugins. * doc/guix.texi (Desktop Services): Document that xfce4-panel plugin packages should be added to the 'packages' field of OS. --- doc/guix.texi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index a21c4d614e..5eb5b47e14 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18563,6 +18563,12 @@ This service adds the @code{xfce} package to the system profile, and extends polkit with the ability for @code{thunar} to manipulate the file system as root from within a user session, after the user has authenticated with the administrator's password. + +Note that @code{xfce4-panel} and its plugin packages should in the same +profile to ensure compatibility, when use this @code{xfce} service, you +should add extra plugins (xfce4-whiskermenu-plugin, +xfce4-weather-plugin, etc.) to the @code{packages} field of your +@code{operating-system}. @end defvr @deftp {Data Type} xfce-desktop-configuration -- 2.29.2