diff mbox series

[bug#36880] reconfigure: Reload all shepherd files when upgrading services.

Message ID 87r266cbte.fsf@sdf.lonestar.org
State Accepted
Headers show
Series [bug#36880] reconfigure: Reload all shepherd files when upgrading services. | expand

Commit Message

Jakob L. Kreuze July 31, 2019, 6:13 p.m. UTC 
Fixes <https://bugs.gnu.org/36878>.
Reported by Robert Vollmert <rob@vllmrt.net>.

* guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Load
all service files, rather than just those of services to be started.
---
 guix/scripts/system/reconfigure.scm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Danny Milosavljevic Aug. 2, 2019, 9:21 a.m. UTC | #1 
I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.

Thanks!
Jakob L. Kreuze Aug. 2, 2019, 3:08 p.m. UTC | #2 
Danny Milosavljevic <dannym@scratchpost.org> writes:

> I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.
>
> Thanks!

Excellent; thank you, Danny!

Regards,
Jakob
diff mbox series

Patch

diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index 8c7d461585..dee0c24bd2 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -161,12 +161,7 @@  services as defined by OS."
                                              target-services)
                                         (map live-service-canonical-name
                                              live-services)))
-             (service-files
-              (map shepherd-service-file
-                   (filter (lambda (service)
-                             (memq (shepherd-service-canonical-name service)
-                                   to-start))
-                           target-services))))
+             (service-files (map shepherd-service-file target-services)))
         (eval #~(primitive-load #$(upgrade-services-program service-files
                                                             to-start
                                                             to-unload