From patchwork Wed Jul 31 18:13:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jakob L. Kreuze" X-Patchwork-Id: 14807 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B14C8172A0; Wed, 31 Jul 2019 19:17:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 7264117266 for ; Wed, 31 Jul 2019 19:17:10 +0100 (BST) Received: from localhost ([::1]:43522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hst9y-00011p-1U for patchwork@mira.cbaines.net; Wed, 31 Jul 2019 14:17:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49861) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hst9r-00011e-7s for guix-patches@gnu.org; Wed, 31 Jul 2019 14:17:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hst9q-0007AV-0H for guix-patches@gnu.org; Wed, 31 Jul 2019 14:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44235) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hst9p-0007AR-U5 for guix-patches@gnu.org; Wed, 31 Jul 2019 14:17:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hst9p-0007Sg-Mm for guix-patches@gnu.org; Wed, 31 Jul 2019 14:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#36880] [PATCH] reconfigure: Reload all shepherd files when upgrading services. Resent-From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 31 Jul 2019 18:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 36880@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156459696428580 (code B ref -1); Wed, 31 Jul 2019 18:17:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jul 2019 18:16:04 +0000 Received: from localhost ([127.0.0.1]:53056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hst8u-0007Qu-7X for submit@debbugs.gnu.org; Wed, 31 Jul 2019 14:16:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:49871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hst8s-0007QK-2v for submit@debbugs.gnu.org; Wed, 31 Jul 2019 14:16:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49644) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hst8r-0000yn-06 for guix-patches@gnu.org; Wed, 31 Jul 2019 14:16:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hst8p-0006jm-2P for guix-patches@gnu.org; Wed, 31 Jul 2019 14:16:00 -0400 Received: from mx.sdf.org ([205.166.94.20]:60495) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hst8o-0006j4-RG for guix-patches@gnu.org; Wed, 31 Jul 2019 14:15:59 -0400 Received: from Epsilon (pool-173-76-53-40.bstnma.fios.verizon.net [173.76.53.40]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id x6VIFt23019619 (using TLSv1.2 with cipher AES256-GCM-SHA384 (256 bits) verified NO) for ; Wed, 31 Jul 2019 18:15:55 GMT From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) Date: Wed, 31 Jul 2019 14:13:01 -0400 Message-ID: <87r266cbte.fsf@sdf.lonestar.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Fixes . Reported by Robert Vollmert . * guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Load all service files, rather than just those of services to be started. --- guix/scripts/system/reconfigure.scm | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm index 8c7d461585..dee0c24bd2 100644 --- a/guix/scripts/system/reconfigure.scm +++ b/guix/scripts/system/reconfigure.scm @@ -161,12 +161,7 @@ services as defined by OS." target-services) (map live-service-canonical-name live-services))) - (service-files - (map shepherd-service-file - (filter (lambda (service) - (memq (shepherd-service-canonical-name service) - to-start)) - target-services)))) + (service-files (map shepherd-service-file target-services))) (eval #~(primitive-load #$(upgrade-services-program service-files to-start to-unload