Message ID | 87czk332an.fsf@reilysiegel.com |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6808127BBEA; Fri, 4 Feb 2022 00:28:00 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3087127BBE9 for <patchwork@mira.cbaines.net>; Fri, 4 Feb 2022 00:28:00 +0000 (GMT) Received: from localhost ([::1]:50932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org>) id 1nFmSF-0003er-Cs for patchwork@mira.cbaines.net; Thu, 03 Feb 2022 19:27:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1nFmRP-0002Le-Po for guix-patches@gnu.org; Thu, 03 Feb 2022 19:27:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1nFmRK-0002Hr-JE for guix-patches@gnu.org; Thu, 03 Feb 2022 19:27:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1nFmRK-0000Bk-GZ for guix-patches@gnu.org; Thu, 03 Feb 2022 19:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53765] [PATCH 15/17] gnu: Add clojure-com-cognitect-aws-s3. References: <87y22r32hi.fsf@reilysiegel.com> In-Reply-To: <87y22r32hi.fsf@reilysiegel.com> Resent-From: Reily Siegel <mail@reilysiegel.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Feb 2022 00:27:02 +0000 Resent-Message-ID: <handler.53765.B53765.1643934382623@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53765 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53765@debbugs.gnu.org Received: via spool by 53765-submit@debbugs.gnu.org id=B53765.1643934382623 (code B ref 53765); Fri, 04 Feb 2022 00:27:02 +0000 Received: (at 53765) by debbugs.gnu.org; 4 Feb 2022 00:26:22 +0000 Received: from localhost ([127.0.0.1]:58340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1nFmQg-00009z-8M for submit@debbugs.gnu.org; Thu, 03 Feb 2022 19:26:22 -0500 Received: from mout-p-101.mailbox.org ([80.241.56.151]:43444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@reilysiegel.com>) id 1nFmQe-00009m-Ne for 53765@debbugs.gnu.org; Thu, 03 Feb 2022 19:26:21 -0500 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4JqbtZ6xVXz9sR2 for <53765@debbugs.gnu.org>; Fri, 4 Feb 2022 01:26:14 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=reilysiegel.com; s=MBO0001; t=1643934372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=IrSpFGEFj6BV5w8nZ+jeNVFYLV68Qe7scW3uIp3JGCo=; b=dXAtM7BKJ6/gMZlZlUukxVypb8ygT93Z003ejzLOVvsEK5KyNgacC8aMvlvzoD559TLliv YWlbf3pm+9BIXD1WY6FfzsP+npL98SvHdD9066Ax3kt3m6CtukKfBA21OcfU8zLiVRLVBc CthJLg0G38Xbz29pierUkhrBsfB3E4g9gUBocT1rP5U7GN3PXA08K3DyAKCLC00GmvlxJ4 5fFv/8vUtZqw4QaiU3vB/tWmRZ6XGhmzsSQop7dSgn6/QzdrxZmf5lr6uDRg8m0s4+ki8K G+RTmirczoxAieMwlgAKUeWIf0kLxXQyL4IB0WcJJpCXXBEfSvURdiiHkpYwRg== From: Reily Siegel <mail@reilysiegel.com> Date: Thu, 03 Feb 2022 19:26:08 -0500 Message-ID: <87czk332an.fsf@reilysiegel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-getmail-retrieved-from-mailbox: Patches |
Series |
Remove limitations on clojure-tools
|
|
Commit Message
Reily Siegel
Feb. 4, 2022, 12:26 a.m. UTC
* gnu/packages/clojure.scm (clojure-com-cognitect-aws-s3): New variable. --- gnu/packages/clojure.scm | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
Comments
Reily Siegel schreef op do 03-02-2022 om 19:26 [-0500]:
> + (synopsis "S3 service description for @code{aws-api}")
I have no idea what that means.
From ‘17.4.4 Synopses and Descriptions’:
[...] Use full sentences, and avoid using acronyms without first
introducing them. [...]
That's strictly speaking only for descriptions, but it's useful advice
for synopses as well.
Greetings,
Maxime.
Reily Siegel schreef op do 03-02-2022 om 19:26 [-0500]: > + (source (origin > + (method url-fetch) > + (uri (string-append "https://repo1.maven.org/maven2/" > + "com/cognitect/aws/s3/" > + version "/s3-" > + version "-sources.jar")) > + [...] > + (license license:asl2.0))) I downloaded it, the hash matches. However, the license appears to be incorrect: specs.clj starts with ;; Copyright (c) Cognitect, Inc. ;; All rights reserved. ‘All rights reserved’ is not ASL2.0, and is blatantly non-free. Also, are you sure this is source code? Aside from the comment above, I don't see any comments or docstrings in specs.clj. Furthermore, service.edn and docs.edn are huge blobs -- it's textual and not binary, but that doesn't make it source code. Greetings, Maxime.
Maxime Devos <maximedevos@telenet.be> writes: > ;; Copyright (c) Cognitect, Inc. > ;; All rights reserved. > > ‘All rights reserved’ is not ASL2.0, and is blatantly non-free. The pom.xml file says that this is ASL2.0 [1] > Also, are you sure this is source code? Aside from the comment above, > I don't see any comments or docstrings in specs.clj. specs.clj just contains what are essentially type definitions. The aws-api library that uses this is declarative, so it only needs to load type definitions, and the edn files that describe the endpoints. > Furthermore, service.edn and docs.edn are huge blobs -- it's textual > and not binary, but that doesn't make it source code. EDN is a strict subset of Clojure used for representing Clojure data structures, similar to JSON for JavaScript. > Greetings, > Maxime.
Reily Siegel schreef op ma 07-02-2022 om 14:56 [-0500]: > > Furthermore, service.edn and docs.edn are huge blobs -- it's > > textual > > and not binary, but that doesn't make it source code. > > EDN is a strict subset of Clojure used for representing Clojure data > structures, similar to JSON for JavaScript. If docs.edn is documentation, should it be in #:doc-dirs? Additionally, this doesn't make it any less a blob. Where does this data come from? Was it written manually by cognitect people? Was some (possibly propietary?) data taken from Amazon and then converted into another data format? How can I edit these files? Greetings, MAxime.
Maxime Devos schreef op za 26-03-2022 om 11:08 [+0100]: > Reily Siegel schreef op ma 07-02-2022 om 14:56 [-0500]: > > > Furthermore, service.edn and docs.edn are huge blobs -- it's > > > textual > > > and not binary, but that doesn't make it source code. > > > > EDN is a strict subset of Clojure used for representing Clojure > data > > structures, similar to JSON for JavaScript. > > If docs.edn is documentation, should it be in #:doc-dirs? > Additionally, this doesn't make it any less a blob. Where does this > data come from? Was it written manually by cognitect people? Was > some > (possibly propietary?) data taken from Amazon and then converted into > another data format? How can I edit these files? More specifically, I noticed that "docs.edn" contains the string Amazon S3 frees up the space used to store the parts and stop charging you for storing them only after you either complete or abort a multipart upload. and so does <https://web.archive.org/web/20220322191400/https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html> but AFAIK Amazon has not released the documentation as ASL2.0. Greetings, Maxime.
Maxime Devos <maximedevos@telenet.be> writes: > If docs.edn is documentation, should it be in #:doc-dirs? It is not documentation, it is a data structure that is used to generate code. > Additionally, this doesn't make it any less a blob. Where does this > data come from? Was it written manually by cognitect people? Was some > (possibly propietary?) data taken from Amazon and then converted into > another data format? How can I edit these files? As I said in response to another package, I can reach out to Cognitect on slack and ask, however based on the previous conversations I have had I strongly suspect they will not want to make any changes ot the package to clarify licensing for the sole benefit of Guix.
Reily Siegel schreef op ma 28-03-2022 om 12:31 [+0200]: > Maxime Devos <maximedevos@telenet.be> writes: > > > If docs.edn is documentation, should it be in #:doc-dirs? > > It is not documentation, it is a data structure that is used to generate > code. The string ‘Amazon S3 frees up the space used to store the parts and stop charging you for storing them only after you either complete or abort a multipart upload.’ and other strings like that look like documentation to me, and I did not see any code reading docs.edn to generate code from it. Greetings, Maxime.
Reily Siegel schreef op ma 28-03-2022 om 12:31 [+0200]: > > Additionally, this doesn't make it any less a blob. Where does > > this > > data come from? Was it written manually by cognitect people? Was > > some > > (possibly propietary?) data taken from Amazon and then converted > > into > > another data format? How can I edit these files? > > As I said in response to another package, I can reach out to > Cognitect on slack and ask, however based on the previous > conversations I have had I strongly suspect they will not want to > make any changes ot the package to clarify licensing for the sole > benefit of Guix. It won't be for the sole benefit of Guix. It would be of the benefit for *everyone* distributing a copy of clojure-com-cognitect-aws-s3 that wants to avoids copyright violation. If the apparent (*) copyright violation and non-freeness cannot be resolved, then I don't think that clojure-com-cognitect-aws-s3 can be included in Guix, given that Guix is not above the (copyright) law and given that software in Guix must be free software. Unless the blob is removed I suppose, in a snippet. (*) as-in, there is no evidence it is not a violation or actually free. Greetings, MMaxime.
Reily Siegel schreef op do 03-02-2022 om 19:26 [-0500]: > + (source (origin > + (method url-fetch) > + (uri (string-append "https://repo1.maven.org/maven2/" > + "com/cognitect/aws/s3/" > + version "/s3-" > + version "-sources.jar")) > + (sha256 > + (base32 The potential license issue appears to have been resolved in the new version: <https://github.com/cognitect-labs/aws-api/issues/208#issuecomment-1088702896>. Greetings, Maxime.
diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm index f4b389f7b0..4979300dc7 100644 --- a/gnu/packages/clojure.scm +++ b/gnu/packages/clojure.scm @@ -324,6 +324,30 @@ (define-public clojure-com-cognitect-aws-endpoints (synopsis "Endpoint data for @code{aws-api}") (license license:asl2.0))) +(define-public clojure-com-cognitect-aws-s3 + (package + (inherit clojure-com-cognitect-aws-api) + (name "clojure-com-cognitect-aws-s3") + (version "814.2.991.0") + (source (origin + (method url-fetch) + (uri (string-append "https://repo1.maven.org/maven2/" + "com/cognitect/aws/s3/" + version "/s3-" + version "-sources.jar")) + (sha256 + (base32 + "0aw3mpddmnjmp45vbmv1l47jn84lgq866fy9mg4wf1x2lqdyhigh")))) + (native-inputs '()) + (propagated-inputs '()) + (arguments + '(#:doc-dirs '() + ;; This package has no tests. + #:tests? #f + #:aot-exclude '(#:all))) + (synopsis "S3 service description for @code{aws-api}") + (license license:asl2.0))) + (define-public clojure-com-cognitect-http-client (package (name "clojure-com-cognitect-aws-api")