diff mbox series

[bug#59560,v2,2/2] gnu: emacs-lpy: Update to fa95b11.

Message ID 20221125061426.23015-2-jgart@dismail.de
State New
Headers show
Series [bug#59560,v2,1/2] gnu: Add emacs-function-args. | expand

Commit Message

jgart Nov. 25, 2022, 6:14 a.m. UTC 
* gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
[propagated-inputs]: Add missing emacs-function-args.
---
 gnu/packages/emacs-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Nicolas Goaziou Nov. 26, 2022, 10:35 a.m. UTC | #1 
Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
> [propagated-inputs]: Add missing emacs-function-args.

Thanks.

> -  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
> -        (revision "5"))
> +  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
> +        (revision "0"))

You should reset revision only when bumping base version. The fact that
commit happen to be sorted in the right order is too subtle. I vote for
(revision "6").

>      (package
>        (name "emacs-lpy")
>        (version (git-version "0.1.0" revision commit))
> @@ -11124,10 +11124,10 @@ (define-public emacs-lpy
>                 (commit commit)))
>           (sha256
>            (base32
> -           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
> +           "1j92ll2afvcp891fxra3sawxg000cs3ra01wxksiil2dg5zpzzkn"))
>           (file-name (git-file-name name version))))
>        (propagated-inputs
> -       (list emacs-zoutline emacs-lispy))
> +       (list emacs-zoutline emacs-lispy emacs-function-args))

While you're at it, could you sort inputs alphabetically, too?

Regards,
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ec1d59931d..b4ab6ec5c3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11111,8 +11111,8 @@  (define-public emacs-function-args
 
 (define-public emacs-lpy
   ;; There is no proper release/tag.
-  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
-        (revision "5"))
+  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
+        (revision "0"))
     (package
       (name "emacs-lpy")
       (version (git-version "0.1.0" revision commit))
@@ -11124,10 +11124,10 @@  (define-public emacs-lpy
                (commit commit)))
          (sha256
           (base32
-           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
+           "1j92ll2afvcp891fxra3sawxg000cs3ra01wxksiil2dg5zpzzkn"))
          (file-name (git-file-name name version))))
       (propagated-inputs
-       (list emacs-zoutline emacs-lispy))
+       (list emacs-zoutline emacs-lispy emacs-function-args))
       (build-system emacs-build-system)
       (home-page "https://github.com/abo-abo/lpy")
       (synopsis "Modal editing for Python")