diff mbox series

[bug#58579,4/4] build-system/gnu: Disable grafts in 'python-build'.

Message ID 20221017064924.2379-4-ludo@gnu.org
State Accepted
Headers show
Series Rewrite grafts using gexps | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git-branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Ludovic Courtès Oct. 17, 2022, 6:49 a.m. UTC 
This is consistent with what 'gnu-build' does and makes sure origins
aren't getting lowered with #:graft? #t in one case and not in the
other.

* guix/build-system/python.scm (python-build): Pass #:graft? #f.
---
 guix/build-system/python.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Liliana Marie Prikler Oct. 17, 2022, 8 a.m. UTC | #1 
Hi Ludo’,

regarding the name of this patch, shouldn't it be "build-system:
python: Disable grafts." or even "build-system: python: Leave grafts
as-is when lowering."?

Am Montag, dem 17.10.2022 um 08:49 +0200 schrieb Ludovic Courtès:
> This is consistent with what 'gnu-build' does and makes sure origins
> aren't getting lowered with #:graft? #t in one case and not in the
> other.
> 
> * guix/build-system/python.scm (python-build): Pass #:graft? #f.
I think mentioning df46bef48eaa43c502fa9193371692c039b460c1 would be
helpful.


The series otherwise LGTM.  I assume you didn't tag it core-updates,
because it doesn't actually cause any rebuilds?

Cheers
Ludovic Courtès Oct. 17, 2022, 4:40 p.m. UTC | #2 
Hi,

Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> skribis:

> regarding the name of this patch, shouldn't it be "build-system:
> python: Disable grafts." or even "build-system: python: Leave grafts
> as-is when lowering."?

It should definitely read “python” and not “gnu”.  It is about disabling
grafts at this stage.

> Am Montag, dem 17.10.2022 um 08:49 +0200 schrieb Ludovic Courtès:
>> This is consistent with what 'gnu-build' does and makes sure origins
>> aren't getting lowered with #:graft? #t in one case and not in the
>> other.
>> 
>> * guix/build-system/python.scm (python-build): Pass #:graft? #f.
> I think mentioning df46bef48eaa43c502fa9193371692c039b460c1 would be
> helpful.

Good idea, will do.

> The series otherwise LGTM.  I assume you didn't tag it core-updates,
> because it doesn't actually cause any rebuilds?

Exactly.

Thank you!

Ludo’.
diff mbox series

Patch

diff --git a/guix/build-system/python.scm b/guix/build-system/python.scm
index efade6f74b..c8f04b2298 100644
--- a/guix/build-system/python.scm
+++ b/guix/build-system/python.scm
@@ -1,5 +1,5 @@ 
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2021 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2013-2017, 2021-2022 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2013 Nikita Karetnikov <nikita@karetnikov.org>
 ;;; Copyright © 2021 Lars-Dominik Braun <lars@6xq.net>
@@ -212,6 +212,7 @@  (define build
                                                   system #:graft? #f)))
     (gexp->derivation name build
                       #:system system
+                      #:graft? #f                 ;consistent with 'gnu-build'
                       #:target #f
                       #:guile-for-build guile)))