mbox series

[bug#58579,0/4] Rewrite grafts using gexps

Message ID 20221017064750.2332-1-ludo@gnu.org
Headers show
Series Rewrite grafts using gexps | expand

Message

Ludovic Courtès Oct. 17, 2022, 6:47 a.m. UTC
Hello Guix!

This patch series rewrites the guts of (guix grafts) using gexps (it
was our last user of ‘build-expression->derivation’).

Incidentally, it fixes <https://issues.guix.gnu.org/58419>.

Feedback welcome!

Ludo’.

Ludovic Courtès (4):
  grafts: Move '%graft?' and related bindings to (guix store).
  Remove now unnecessary uses of (guix grafts).
  grafts: Rewrite using gexps.
  build-system/gnu: Disable grafts in 'python-build'.

 gnu/ci.scm                   |   3 +-
 guix/build-system/python.scm |   3 +-
 guix/gexp.scm                |   1 -
 guix/grafts.scm              | 144 +++++++++++++----------------------
 guix/lint.scm                |   1 -
 guix/scripts.scm             |   1 -
 guix/scripts/archive.scm     |   1 -
 guix/scripts/build.scm       |   3 -
 guix/scripts/challenge.scm   |   1 -
 guix/scripts/deploy.scm      |   1 -
 guix/scripts/environment.scm |   1 -
 guix/scripts/home.scm        |   1 -
 guix/scripts/pack.scm        |   1 -
 guix/scripts/package.scm     |   1 -
 guix/scripts/pull.scm        |   1 -
 guix/scripts/size.scm        |   1 -
 guix/scripts/system.scm      |   1 -
 guix/scripts/weather.scm     |   1 -
 guix/store.scm               |  36 +++++++++
 tests/builders.scm           |   1 -
 tests/channels.scm           |   1 -
 tests/cpan.scm               |   2 +-
 tests/derivations.scm        |   1 -
 tests/gexp.scm               |   1 -
 tests/graph.scm              |   1 -
 tests/guix-daemon.sh         |   4 +-
 tests/monads.scm             |   1 -
 tests/pack.scm               |   1 -
 tests/packages.scm           |   1 -
 tests/profiles.scm           |   1 -
 tests/system.scm             |   1 -
 31 files changed, 93 insertions(+), 126 deletions(-)


base-commit: 4dfaddfc44d3a05db7ad9720b8d8942aec3a1d7f
prerequisite-patch-id: 7016063f1ce703056f764119e0c3c27692487caf

Comments

Ludovic Courtès Oct. 21, 2022, 11:51 p.m. UTC | #1
Hi,

Ludovic Courtès <ludo@gnu.org> skribis:

>   grafts: Move '%graft?' and related bindings to (guix store).
>   Remove now unnecessary uses of (guix grafts).
>   grafts: Rewrite using gexps.
>   build-system/gnu: Disable grafts in 'python-build'.

I took Liliana’s suggestion into account and pushed as
863c228bfd53aac478eee46f6ee54d87fee9d764.

Thanks,
Ludo’.