diff mbox series

[bug#56248,1/7] gnu: recutils: Use regular check version

Message ID 20220627050217.132640-1-bauermann@kolabnow.com
State Accepted
Headers show
Series Remove use of older check-0.14 from most packages | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Thiago Jung Bauermann June 27, 2022, 5:02 a.m. UTC 
recutils builds fine with the regular version of check, so use it.

* gnu/packages/databases.scm (recutils)[native-inputs]: Use regular version of
check.
---
 gnu/packages/databases.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Liliana Marie Prikler June 27, 2022, 6:04 a.m. UTC | #1 
Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann:
> recutils builds fine with the regular version of check, so use it.
Mostly duplicate information.  Also you're missing the period at the
end of the message title.  I suggest shortening it to “gnu: recutils:
Use regular check.”

> * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular
> version of check.
Should be “Replace check-0.14 with check.” or similar.


Likewise for all the other patches, otherwise LGTM.
Thiago Jung Bauermann July 2, 2022, 4:09 a.m. UTC | #2 
Hello Liliana,

Thank you for your prompt review!

Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> writes:

> Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann:
>> recutils builds fine with the regular version of check, so use it.
> Mostly duplicate information.  Also you're missing the period at the
> end of the message title.  I suggest shortening it to “gnu: recutils:
> Use regular check.”
>
>> * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular
>> version of check.
> Should be “Replace check-0.14 with check.” or similar.
>
>
> Likewise for all the other patches, otherwise LGTM.

These are good points. I adopted your suggestions in the v2.
diff mbox series

Patch

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 72200fce92d0..0d4405ef90e5 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1577,7 +1577,7 @@  (define-public recutils
      ;; XXX Without labels, the default 'configure phase picks the wrong "bash".
      `(("bc" ,bc)
        ("bash:include" ,bash "include")
-       ("check" ,check-0.14)
+       ("check" ,check)
        ("pkg-config" ,pkg-config)))
     (inputs
      ;; TODO: Add more optional inputs.