Message ID | 20220627050217.132640-1-bauermann@kolabnow.com |
---|---|
State | Accepted |
Headers | show |
Series | Remove use of older check-0.14 from most packages | expand |
Context | Check | Description |
---|---|---|
cbaines/comparison | success | View comparision |
cbaines/git branch | success | View Git branch |
cbaines/applying patch | success | View Laminar job |
cbaines/issue | success | View issue |
Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann: > recutils builds fine with the regular version of check, so use it. Mostly duplicate information. Also you're missing the period at the end of the message title. I suggest shortening it to “gnu: recutils: Use regular check.” > * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular > version of check. Should be “Replace check-0.14 with check.” or similar. Likewise for all the other patches, otherwise LGTM.
Hello Liliana, Thank you for your prompt review! Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> writes: > Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann: >> recutils builds fine with the regular version of check, so use it. > Mostly duplicate information. Also you're missing the period at the > end of the message title. I suggest shortening it to “gnu: recutils: > Use regular check.” > >> * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular >> version of check. > Should be “Replace check-0.14 with check.” or similar. > > > Likewise for all the other patches, otherwise LGTM. These are good points. I adopted your suggestions in the v2.
diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm index 72200fce92d0..0d4405ef90e5 100644 --- a/gnu/packages/databases.scm +++ b/gnu/packages/databases.scm @@ -1577,7 +1577,7 @@ (define-public recutils ;; XXX Without labels, the default 'configure phase picks the wrong "bash". `(("bc" ,bc) ("bash:include" ,bash "include") - ("check" ,check-0.14) + ("check" ,check) ("pkg-config" ,pkg-config))) (inputs ;; TODO: Add more optional inputs.