| Message ID | cover.1729985174.git.jesse@eisses.email |
|---|---|
| Headers | show |
| Series | Add ledger hardware wallet support | expand |
Hello Jesse, thanks for your contribution, which passes QA and looks mainly good! QA runs "guix lint": https://qa.guix.gnu.org/issue/74039 which complains about the following: "the source file name should contain the package name" Maybe you could run "guix lint" on your different packages and see to which one it applies? Probably python-bip32 with its source taken from git. Maybe you could use pypi there as well? When trying a "guix import pypi bip32" I get a version 4.0 instead of 3.2; would this work as well? Otherwise, there are examples in the Guix source of how to force a descriptive name for the git checkout. The description should consist of complete sentences and be a bit longer and more descriptive, maybe a short paragraph. Often it can be taken from the project website, after stripping out the marketing speech. Please also adapt the commit messages to the Guix style. Running "./etc/committer.scm" (instead of "git commit") could be an option, it usually works well for adding new packages. Looking forward to a v3, Andreas
From: Jesse Eisses <jesse@eisses.email> This patch adds ledger hardware wallet support to electrum. Several additional Python packages are needed this: https://electrum.readthedocs.io/en/latest/hardware-linux.html After adding the dependencies to electrum it's possible to access ledger within electrum. Jesse Eisses (5): gnu: Add python-ledgercomm gnu: Add python-coincurve gnu: Add python-bip32 gnu: Add python-ledger-bitcoin gnu: Add ledger hardware wallet support to electrum gnu/packages/finance.scm | 99 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) base-commit: 269e4034fcaf55324187efffb6ed5ba14d5e9286