mbox series

[bug#69652,gnome-team,v2,0/3] FIX that damn orbit2

Message ID cover.1709974034.git.vivien@planete-kraus.eu
Headers show
Series FIX that damn orbit2 | expand

Message

Vivien Kraus March 9, 2024, 8:47 a.m. UTC 
Dear Guix,

Our new glib was the first to not let orbit2 get away with terrible bad
practice.  I explained the situation in the patch.

Best regards,

Vivien

Vivien Kraus (3):
  gnu: orbit2: Update style.
  gnu: orbit2: Propagate inputs.
  gnu: orbit2: Fix bug on 32-bit systems.

 gnu/local.mk                                  |  1 +
 gnu/packages/gnome.scm                        | 61 ++++++++++---------
 .../orbit2-fix-array-allocation-32bit.patch   | 40 ++++++++++++
 3 files changed, 73 insertions(+), 29 deletions(-)
 create mode 100644 gnu/packages/patches/orbit2-fix-array-allocation-32bit.patch


base-commit: 25c14c893f05019d746321285acf55d1aa65b943

Comments

Maxim Cournoyer March 9, 2024, 5:50 p.m. UTC | #1 
Hi!

Vivien Kraus <vivien@planete-kraus.eu> writes:

> Dear Guix,
>
> Our new glib was the first to not let orbit2 get away with terrible bad
> practice.  I explained the situation in the patch.
>
> Best regards,
>
> Vivien
>
> Vivien Kraus (3):
>   gnu: orbit2: Update style.
>   gnu: orbit2: Propagate inputs.
>   gnu: orbit2: Fix bug on 32-bit systems.
>
>  gnu/local.mk                                  |  1 +

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Liliana Marie Prikler March 9, 2024, 6:40 p.m. UTC | #2 
Am Samstag, dem 09.03.2024 um 12:50 -0500 schrieb Maxim Cournoyer:
> Hi!
> 
> Vivien Kraus <vivien@planete-kraus.eu> writes:
> 
> > Dear Guix,
> > 
> > Our new glib was the first to not let orbit2 get away with terrible
> > bad practice.  I explained the situation in the patch.
> > 
> > Best regards,
> > 
> > Vivien
> > 
> > Vivien Kraus (3):
> >   gnu: orbit2: Update style.
> >   gnu: orbit2: Propagate inputs.
> >   gnu: orbit2: Fix bug on 32-bit systems.
> > 
> >  gnu/local.mk                                  |  1 +
> 
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
And pushed.