mbox series

[bug#68937,0/3] Orca fixes

Message ID cover.1707146219.git.dariqq@posteo.net
Headers
Series Orca fixes |

Message

Dariqq Feb. 5, 2024, 3:44 p.m. UTC 
Hi,

As reported in https://issues.guix.gnu.org/64357 orca currently fails to run.

The issue seems to be that the 'import pyatspi' statement fails when at-spi2-atk is in 'GI_TYPELIB_PATH' with the changes to the '__init__.py' done in the python-pyatspi guix package. I have removed the at-spi2-atk package and at least orca is not complaining.

Then there was also the issue that orca was not able to find the orca modules which was solved by adding them to GUIX_PYTHONPATH.

This makes orca able to run again.

I also added some of the optional dependencies to orca which required fixing the brltty package first.

Dariqq (3):
  gnu: orca: Fix invocation errors.
  gnu: brltty: Fix python package install.
  gnu: orca: Add more optional dependencies.

 gnu/packages/accessibility.scm | 10 +++++++-
 gnu/packages/gnome.scm         | 46 +++++++++++++++++++++-------------
 2 files changed, 37 insertions(+), 19 deletions(-)


base-commit: 179bb57d2532ee6b81791e078b0f782cbf88cb84

Comments

Vivien Kraus Feb. 5, 2024, 4:50 p.m. UTC | #1 
Hello!

Le lundi 05 février 2024 à 15:44 +0000, Dariqq a écrit :
> As reported in https://issues.guix.gnu.org/64357 orca currently fails
> to run.
I believe this specific issue does not arise anymore with orca 44.2 on
gnome-team: it does some screen reading. Does it fix your issue?
Otherwise, could you rebase your work on top of gnome-team ?

Best regards,

Vivien
Dariqq Feb. 5, 2024, 6:32 p.m. UTC | #2 
Hi Vivien,

I think I messed something up when I tried to check the gnome-team 
version earlier today. Checked again now and orca-44.2 is working. So 
please ignore patch 1.

I'll rebase patches 2 and 3 on gnome-team enabling liblouis and brltty 
in orca and send them again.


On 05.02.24 17:50, Vivien Kraus wrote:
> Hello!
> 
> Le lundi 05 février 2024 à 15:44 +0000, Dariqq a écrit :
>> As reported in https://issues.guix.gnu.org/64357 orca currently fails
>> to run.
> I believe this specific issue does not arise anymore with orca 44.2 on
> gnome-team: it does some screen reading. Does it fix your issue?
> Otherwise, could you rebase your work on top of gnome-team ?
> 
> Best regards,
> 
> Vivien
Vivien Kraus Feb. 10, 2024, 8:12 a.m. UTC | #3 
user guix
usertag 68937 + reviewed-looks-good
thanks

Guix QA review form submission:
The new lint warning is Guix’ fault I think.

I checked orca and it still reads the screen correctly. I’m not a
regular user of orca.

I’m not a maintainer, I’m not a committer. I’m a relatively new member
of the GNOME team.

I’ve been involved as I asked for the patches to be rebased on gnome-
team.

Items marked as checked: Package builds, Commit messages
Christopher Baines Feb. 10, 2024, 11:11 a.m. UTC | #4 
Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:

> user guix
> usertag 68937 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
> The new lint warning is Guix’ fault I think.
>
> I checked orca and it still reads the screen correctly. I’m not a
> regular user of orca.
>
> I’m not a maintainer, I’m not a committer. I’m a relatively new member
> of the GNOME team.
>
> I’ve been involved as I asked for the patches to be rebased on gnome-
> team.
>
> Items marked as checked: Package builds, Commit messages

Thanks both, unfortunately QA is not very useful for gnome-team at the
moment since it hasn't started building it. The builds for this issue
were also blocked by builtin:git-download related
failures.

The changes look fine to me though, so I've pushed both patches to
gnome-team as 952c691b51f8f5d56df69686c2785414709c7949.

Thanks,

Chris
Christopher Baines Feb. 10, 2024, 11:15 a.m. UTC | #5 
Christopher Baines <mail@cbaines.net> writes:

> [[PGP Signed Part:Good signature from 5E28A33B0B84F577 Christopher Baines <mail@cbaines.net> (trust ultimate) created at 2024-02-10T11:13:32+0000 using RSA]]
>
> Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:
>
>> user guix
>> usertag 68937 + reviewed-looks-good
>> thanks
>>
>> Guix QA review form submission:
>> The new lint warning is Guix’ fault I think.
>>
>> I checked orca and it still reads the screen correctly. I’m not a
>> regular user of orca.
>>
>> I’m not a maintainer, I’m not a committer. I’m a relatively new member
>> of the GNOME team.
>>
>> I’ve been involved as I asked for the patches to be rebased on gnome-
>> team.
>>
>> Items marked as checked: Package builds, Commit messages
>
> Thanks both, unfortunately QA is not very useful for gnome-team at the
> moment since it hasn't started building it. The builds for this issue
> were also blocked by builtin:git-download related
> failures.
>
> The changes look fine to me though, so I've pushed both patches to
> gnome-team as 952c691b51f8f5d56df69686c2785414709c7949.

Forgot to close.