From patchwork Sat Nov 20 18:08:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Kehayias X-Patchwork-Id: 34708 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 55A9B27BBE3; Sat, 20 Nov 2021 18:09:09 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1CE0427BBE1 for ; Sat, 20 Nov 2021 18:09:09 +0000 (GMT) Received: from localhost ([::1]:40024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moUnU-00069V-6B for patchwork@mira.cbaines.net; Sat, 20 Nov 2021 13:09:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moUnO-00069M-M9 for guix-patches@gnu.org; Sat, 20 Nov 2021 13:09:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moUnO-0000rl-E0 for guix-patches@gnu.org; Sat, 20 Nov 2021 13:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moUnO-0001lh-7G for guix-patches@gnu.org; Sat, 20 Nov 2021 13:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51987] [PATCH] [core-updates-frozen] gnu: ledger: Remove failing test output. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51987 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Guillaume Le Vaillant Cc: 51987@debbugs.gnu.org Received: via spool by 51987-submit@debbugs.gnu.org id=B51987.16374317106744 (code B ref 51987); Sat, 20 Nov 2021 18:09:02 +0000 Received: (at 51987) by debbugs.gnu.org; 20 Nov 2021 18:08:30 +0000 Received: from localhost ([127.0.0.1]:43645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moUms-0001ki-ER for submit@debbugs.gnu.org; Sat, 20 Nov 2021 13:08:30 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:20507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moUmn-0001kO-3u for 51987@debbugs.gnu.org; Sat, 20 Nov 2021 13:08:28 -0500 Date: Sat, 20 Nov 2021 18:08:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1637431698; bh=892U5xmIEHP9VzsZwoKH+y482wXuD0qWahzJkQxu898=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=vZWokDuhmJYFM7qYAOSAtsI3t4O+WwAXrBt1vG0ESZz+8jntdi3L/lF+dnTGtGIQR GPLKW2cOrkSFdUHQZ+1DIkdQymwJ1wbbWNIK3+uvaasQqHk9eyuLbFHcZ+51IQTJ8m RYNQ5BtjnOuz9PYIW4MooUW9jgJx0Te5/V4i3pWU= Message-ID: In-Reply-To: <87k0h3xjnp.fsf@kitej> References: <87k0h3xjnp.fsf@kitej> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches X-Patchwork-Original-From: John Kehayias via Guix-patches via From: John Kehayias X-getmail-retrieved-from-mailbox: Patches Hello, ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Saturday, November 20th, 2021 at 4:19 AM, Guillaume Le Vaillant wrote: > Instead of adding a patch removing the file, wouldn't it be simpler to just add a phase > calling '(delete-file "test/...")'? That's a very good point, much easier! I've attached v2 of the patch (commit message also had a typo before) where I used a snippet to remove the file. I haven't written a snippet before but seemed like a clean and explicit way to do the source modification here. Hope that's better! John From 49cfab2b6c52bd0be59f17f9bbcd669937beb2a6 Mon Sep 17 00:00:00 2001 From: John Kehayias Date: Sat, 20 Nov 2021 13:02:25 -0500 Subject: [PATCH V2] gnu: ledger: Remove failing test output. * gnu/packages/finance.scm (ledger)[source]: Add snippet to remove a failing test. --- gnu/packages/finance.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 354a2f2e0f..0c045b7bd3 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -25,6 +25,7 @@ ;;; Copyright © 2021 ZmnSCPxj jxPCSnmZ ;;; Copyright © 2021 François J ;;; Copyright © 2021 Foo Chuan Wei +;;; Copyright © 2021 John Kehayias ;;; ;;; This file is part of GNU Guix. ;;; @@ -304,7 +305,14 @@ (define-public ledger (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "0x6jxwss3wwzbzlwmnwb8yzjk8f9wfawif4f1b74z2qg6hc4r7f6")))) + (base32 "0x6jxwss3wwzbzlwmnwb8yzjk8f9wfawif4f1b74z2qg6hc4r7f6")) + (snippet '(begin + ;; Remove test that fails due to difference in + ;; reported error message (missing leading "./" in the + ;; file name); started some time after Guix commit + ;; 727f05e1e285aa52f5a19ec923fdc2259859b4b1 + (delete-file "test/regress/BF3C1F82-2.test") + #true)))) (build-system cmake-build-system) (arguments `(#:modules (,@%cmake-build-system-modules -- 2.33.1