| Message ID | cover.1705854493.git.sharlatanus@gmail.com |
|---|---|
| Headers | show |
| Series | gnu: Astronomy 2024/01 updates. | expand |
Hello Sharlatan! Sharlatan Hellseher <sharlatanus@gmail.com> writes: > Hi Guix, > > The first update for this year including new packages, updates and refactoring > of exiting ones. > > I'd like to highlight archived milestones: > * Each of disabled test has annotation > * All packages use G-Expression and no label style > * The number of packages using python-build-system reduced to 7 > * Nearly all of the packages are on the latest upstream release versions > * There is non failing packages > * Number of packages are 107 > > In the next update cycle, I would add more new packages and update > python-astropy to the latest upstream release. Astropy v6.0.0 dropped support > for setup.py and now completely relies on pyproject.toml, which may require > additional work to build extensions. There is a known issue in the Python > community, which can be found at > https://github.com/pypa/setuptools/discussions/3388. Thank you! This is all very neatly crafted and tested. The attention to detail is much appreciated. [...] > Sharlatan Hellseher (19): > gnu: stellarium: Update to 23.4. > gnu: indi-2.0: Update to 2.0.5. > gnu: gpredict: Update home-page and description. > gnu: libxisf: Update to 0.2.11. > gnu: python-crds: Update to 11.17.14. > gnu: python-drms: Update to 0.7.1. > gnu: python-pyvo: Update to 1.5. > gnu: python-stcal: Update to 1.5.2. > gnu: python-sunpy: Update to 5.1.1. > gnu: Add python-ndcube. > gnu: Add python-dust-extinction. > gnu: Add python-specutils. > gnu: python-synphot: Enable more options. > gnu: python-tweakwcs: Update to 0.8.6. > gnu: python-skyfield: Update to 1.47. > gnu: python-stsynphot: Fix build. > gnu: libpasastro: Use G-Expressions. > gnu: stackistry: Use G-Expressions. > gnu: libnova: Use G-Expressions. > I've added a few mostly innocuous comments in one or two of the series. Feel free to adjust as you see fit and push the series. Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Hi Efraim, Thank you for the review and feedback! > This package compiles just fine for riscv64 so there's no reason to > limit it to only certain architectures. That's is a great new, I did not try to build it on any other OS or platform. The reason I've add that flags is not a standard Makfile coming with the project. https://github.com/pchev/libpasastro/blob/master/Makefile --8<---------------cut here---------------start------------->8--- all: ifeq ($(OS_TARGET),win32) $(MAKE) -C getdss -f Makefile.win32 all $(MAKE) -C plan404 -f Makefile.win32 all $(MAKE) -C wcs -f Makefile.win32 all else ifeq ($(OS_TARGET),win64) $(MAKE) -C getdss -f Makefile.win64 all $(MAKE) -C plan404 -f Makefile.win64 all $(MAKE) -C wcs -f Makefile.win64 all else ifeq ($(CPU_TARGET),i386) $(MAKE) -C getdss all arch_flags=-m32 $(MAKE) -C plan404 all arch_flags=-m32 $(MAKE) -C wcs all arch_flags=-m32 else ifeq ($(CPU_TARGET),x86_64) $(MAKE) -C getdss all arch_flags=-m64 $(MAKE) -C plan404 all arch_flags=-m64 $(MAKE) -C wcs all arch_flags=-m64 else $(MAKE) -C getdss all $(MAKE) -C plan404 all $(MAKE) -C wcs all endif endif endif endif clean: ifeq ($(OS_TARGET),win32) $(MAKE) -C getdss -f Makefile.win32 clean $(MAKE) -C plan404 -f Makefile.win32 clean $(MAKE) -C wcs -f Makefile.win32 clean else ifeq ($(OS_TARGET),win64) $(MAKE) -C getdss -f Makefile.win64 clean $(MAKE) -C plan404 -f Makefile.win64 clean $(MAKE) -C wcs -f Makefile.win64 clean else $(MAKE) -C getdss clean $(MAKE) -C plan404 clean $(MAKE) -C wcs clean endif endif ifeq ($(OS_TARGET),darwin) install: ./install_darwin.sh $(PREFIX) else install: ./install.sh $(PREFIX) $(CPU_TARGET) install_win: ./install_win.sh win32 $(PREFIX) install_win64: ./install_win.sh win64 $(PREFIX) endif --8<---------------cut here---------------end--------------->8--- > (%current-target-system) returns i686-linux-gnu for the first one, so > it'd probably be better to use cond and (target-x86-32?) for the first > one. > > I'm not actually convinced you need any of the flags for OS_TARGET or > CPU_TARGET (except perhaps for cross-compiling), does it make a > difference between compiled with or without? I would dedicate some time to figure out how to satisfy custom Makefile to be compatible for larger range of systems available in Guix. Putting to my TODO for 2024/02 updates. Regards, Oleg
Hi Maxim, > This is all very neatly crafted and tested. The attention to detail is > much appreciated. Thank you for worm feedback! I've amended mentioned commit log and comments. Pushed as 2266754382..8f86cbd5e9 to master. Regards, Oleg
worm -> wArm =) It was long day.... Thanks, Oleg -- VCS: https://github.incerto.xyz/; https://git.sr.ht/~hellseher/ GPG: 9847 81DE 689C 21C2 6418 0867 76D7 27BF F62C D2B5 … наш разум - превосходная объяснительная машина которая способна найти смысл почти в чем угодно, истолковать любой феномен, но совершенно не в состоянии принять мысль о непредсказуемости.