mbox series

[bug#67814,0/3] gnu: mpv: Update to 0.37.0.

Message ID cover.1702486251.git.zhengjunjie@iscas.ac.cn
Headers show
Series gnu: mpv: Update to 0.37.0. | expand

Message

Zheng Junjie Dec. 13, 2023, 4:53 p.m. UTC 
gnu: mpv: Update to 0.37.0.

Zheng Junjie (3):
  gnu: glad: Update to 2.0.4.
  gnu: libplacebo: Update to 6.338.1.
  gnu: mpv: Update to 0.37.0.

 gnu/packages/electronics.scm |  3 ++-
 gnu/packages/gl.scm          | 50 +++++++++++++++++++++++++++---------
 gnu/packages/video.scm       | 42 +++++++++++++++---------------
 3 files changed, 61 insertions(+), 34 deletions(-)


base-commit: 5f812344d293e5faaca44eeaab3b889fa6cb7e33

Comments

Hilton Chain Dec. 22, 2023, 2:33 p.m. UTC | #1 
Hi,

On Thu, 14 Dec 2023 00:53:46 +0800,
Zheng Junjie wrote:
>
> gnu: mpv: Update to 0.37.0.
>
> Zheng Junjie (3):
>   gnu: glad: Update to 2.0.4.

Moved python-jinja2 from inputs to propagated-inputs, applied as
1784ece7cb61dc72a43cf8e0ad17fdbb266320e6.

>   gnu: libplacebo: Update to 6.338.1.

Applied as fbc6683ebba637b5321e7068a9249f7d562cd65a.

>   gnu: mpv: Update to 0.37.0.

Applied as ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53.

I have also made some adjustments in commit messages, gexps and inputs
order, you may notice them in above commits.

Thanks!
Andrew Tropin Dec. 25, 2023, 11:33 a.m. UTC | #2 
On 2023-12-22 22:33, Hilton Chain via Guix-patches via wrote:

> Hi,
>
> On Thu, 14 Dec 2023 00:53:46 +0800,
> Zheng Junjie wrote:
>>
>> gnu: mpv: Update to 0.37.0.
>>
>> Zheng Junjie (3):
>>   gnu: glad: Update to 2.0.4.
>
> Moved python-jinja2 from inputs to propagated-inputs, applied as
> 1784ece7cb61dc72a43cf8e0ad17fdbb266320e6.
>
>>   gnu: libplacebo: Update to 6.338.1.
>
> Applied as fbc6683ebba637b5321e7068a9249f7d562cd65a.
>
>>   gnu: mpv: Update to 0.37.0.
>
> Applied as ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53.
>
> I have also made some adjustments in commit messages, gexps and inputs
> order, you may notice them in above commits.

Hi Hilton!

It seem the mpv update breaks mpv-mpris build.  I didn't dive into
issue yet, only tried to revert this patch.
Hilton Chain Jan. 5, 2024, 5:09 a.m. UTC | #3 
Hi,

On Mon, 25 Dec 2023 19:33:41 +0800,
Andrew Tropin wrote:
>
> Hi Hilton!
>
> It seem the mpv update breaks mpv-mpris build.  I didn't dive into
> issue yet, only tried to revert this patch.

It's because mpv's pkgconfig file (for libmpv) now includes all its
dependencies in Requires.private.  Sorry that I didn't check all the
dependent packages.

Josselin has sent bug#68044, which adds mpv's inputs to mpv-mpris.

However there're actually other packages depend on libmpv, so I think
the proper fix is to split libmpv from the mpv package and propagate
inputs in a new package (as mpv users are likely to include mpv in
their profiles, thus these propagated inputs are usually unwanted).

I tried to add a "lib" output for mpv first but there would be cycles.
As a result, I disabled libmpv in mpv, added a libmpv package which
inherits from mpv, and sent it to bug#68250.

Thanks