mbox series

[bug#65336,0/2] Update looking-glass-client to B6 and restyle package

Message ID cover.1692176991.git.a.r.draidi@redscript.org
Headers show
Series Update looking-glass-client to B6 and restyle package | expand

Message

Ahmad Draidi Aug. 16, 2023, 9:15 a.m. UTC 
Hello Guix,

This series updates and restyles looking-glass-client, and also restores a
configuration parameter that was dropped in the previous update patch. Some
notes for posterity below.

The package builds with "-march=native" GCC parameter by default, which
makes it incompatible with CPUs older than the build machine and causes
crashes with "terminated by signal SIGILL (Illegal instruction)" and perhaps
others. We build it with the minimum supported CPU architecture to fix that.
This also helps with package reproducibility.

Thanks,

Ahmad Draidi (2):
  gnu: looking-glass-client: Update to B6.
  gnu: looking-glass-client: Update package style.

 gnu/packages/virtualization.scm | 146 ++++++++++++++++----------------
 1 file changed, 73 insertions(+), 73 deletions(-)


base-commit: 880ada0bdb9e694573ec42200d48658b27744b9b

Comments

Christopher Baines Aug. 29, 2023, 1:05 p.m. UTC | #1 
Ahmad Draidi via Guix-patches via <guix-patches@gnu.org> writes:

> This series updates and restyles looking-glass-client, and also restores a
> configuration parameter that was dropped in the previous update patch. Some
> notes for posterity below.
>
> The package builds with "-march=native" GCC parameter by default, which
> makes it incompatible with CPUs older than the build machine and causes
> crashes with "terminated by signal SIGILL (Illegal instruction)" and perhaps
> others. We build it with the minimum supported CPU architecture to fix that.
> This also helps with package reproducibility.
>
> Thanks,
>
> Ahmad Draidi (2):
>   gnu: looking-glass-client: Update to B6.
>   gnu: looking-glass-client: Update package style.
>
>  gnu/packages/virtualization.scm | 146 ++++++++++++++++----------------
>  1 file changed, 73 insertions(+), 73 deletions(-)

Thanks Ahmad, these changes look good to me. I've pushed to master as
02e32197a80e4fc323ffe0e519ad4e58f206fc5d.