mbox series

[bug#64875,0/4] Adding xsv

Message ID cover.1690386417.git.w@wmeyer.eu
Headers show
Series Adding xsv | expand

Message

Wilko Meyer July 26, 2023, 3:49 p.m. UTC 
Hi Guix,

I'd like to add xsv, which is a csv cli toolkit, to guix packages. It
has two dependencies, rust-chan-0.1 and rust-filetime-0.1, which I've
added in this patch series as well. As this is my first time adding
something to guix packages I tried to be as close to the guix manual as
possible, please let me know if there's still something missing/if
there's something I can do to further improve the quality of my patches.

Best Regards,

Wilko Meyer

Wilko Meyer (4):
  gnu: Added rust-chan-0.1.
  gnu: Added rust-filetime-0.1 variant.
  gnu: Added xsv.
  gnu: Added copyright information.

 gnu/packages/crates-io.scm | 40 ++++++++++++++++++++++++++++++++++++++
 gnu/packages/rust-apps.scm | 36 ++++++++++++++++++++++++++++++++++
 2 files changed, 76 insertions(+)


base-commit: e05dcecd0df49a397aba49585a626cae16a6306c

Comments

Christopher Baines Oct. 5, 2023, 10:22 a.m. UTC | #1 
Wilko Meyer <w@wmeyer.eu> writes:

> I'd like to add xsv, which is a csv cli toolkit, to guix packages. It
> has two dependencies, rust-chan-0.1 and rust-filetime-0.1, which I've
> added in this patch series as well. As this is my first time adding
> something to guix packages I tried to be as close to the guix manual as
> possible, please let me know if there's still something missing/if
> there's something I can do to further improve the quality of my patches.
>
> Best Regards,
>
> Wilko Meyer
>
> Wilko Meyer (4):
>   gnu: Added rust-chan-0.1.
>   gnu: Added rust-filetime-0.1 variant.
>   gnu: Added xsv.
>   gnu: Added copyright information.
>
>  gnu/packages/crates-io.scm | 40 ++++++++++++++++++++++++++++++++++++++
>  gnu/packages/rust-apps.scm | 36 ++++++++++++++++++++++++++++++++++
>  2 files changed, 76 insertions(+)
>
>
> base-commit: e05dcecd0df49a397aba49585a626cae16a6306c

Hi Wilko,

Thanks for sending these patches. I think there's an issue with xsv as
one of the inputs (rust-csv-index) doesn't seem to exist.

Do these new packages build for you on your system?

Thanks,

Chris
Wilko Meyer Oct. 5, 2023, 1:25 p.m. UTC | #2 
Hi Chris,

Thanks for reviewing my patch series!

Christopher Baines <mail@cbaines.net> writes:

> Thanks for sending these patches. I think there's an issue with xsv as
> one of the inputs (rust-csv-index) doesn't seem to exist.

You're right, I forgot to include rust-csv-index in this patch series,
but already had it locally, which is why I was able to build xsv without
noticing it. I'll include a patch to add rust-csv-index in a minute.

Others than that, and with rust-csv-index included, it should build (at
least it does so for me locally)/work fine:

wilko@guix230 ~/devel/guix [env]$ xsv --version
0.13.0
Christopher Baines Oct. 11, 2023, 10:16 a.m. UTC | #3 
Wilko Meyer <w@wmeyer.eu> writes:

> Thanks for reviewing my patch series!
>
> Christopher Baines <mail@cbaines.net> writes:
>
>> Thanks for sending these patches. I think there's an issue with xsv as
>> one of the inputs (rust-csv-index) doesn't seem to exist.
>
> You're right, I forgot to include rust-csv-index in this patch series,
> but already had it locally, which is why I was able to build xsv without
> noticing it. I'll include a patch to add rust-csv-index in a minute.

I see the new patch now.

The other simple thing I notice is that the commit messages should be in
the present tense (so Add rather than Added). Would you be able to fix
that and then resend the entire series? It's always useful to send all
the patches again when you make changes, as that simplifies the job for
anyone trying to get the latest patches.

Thanks,

Chris