mbox series

[bug#44922,0/6] Prometheus node exporter service enhancements

Message ID 87zh31u1q0.fsf@cbaines.net
Headers show
Series Prometheus node exporter service enhancements | expand

Message

Christopher Baines Nov. 28, 2020, 12:04 p.m. UTC 
Some patches to enhance the Prometheus node exporter service.

Christopher Baines (6):
  services: monitoring: Neaten up the Prometheus node exporter.
  monitoring: Add user and group for the Prometheus node exporter.
  services: monitoring: Use a log file for Prometheus node exporter.
  doc: Remove redundant node exporter configuration from the example.
  monitoring: Enable the Prometheus node exporter textfile collector.
  monitoring: Support extra options for the Prometheus node exporter.

 doc/guix.texi               | 15 ++++---
 gnu/services/monitoring.scm | 81 ++++++++++++++++++++++++++++++-------
 2 files changed, 76 insertions(+), 20 deletions(-)

Comments

Ludovic Courtès Dec. 6, 2020, 10:27 p.m. UTC | #1 
Hi,

Christopher Baines <mail@cbaines.net> skribis:

>   services: monitoring: Neaten up the Prometheus node exporter.
>   monitoring: Add user and group for the Prometheus node exporter.
>   services: monitoring: Use a log file for Prometheus node exporter.
>   doc: Remove redundant node exporter configuration from the example.
>   monitoring: Enable the Prometheus node exporter textfile collector.
>   monitoring: Support extra options for the Prometheus node exporter.
    ^
Should be “services: prometheus-node-exporter: …”.

Apart from that, on a quick look it LGTM.  Go for it!

Thanks,
Ludo’.
Christopher Baines Dec. 7, 2020, 9:22 a.m. UTC | #2 
Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>>   services: monitoring: Neaten up the Prometheus node exporter.
>>   monitoring: Add user and group for the Prometheus node exporter.
>>   services: monitoring: Use a log file for Prometheus node exporter.
>>   doc: Remove redundant node exporter configuration from the example.
>>   monitoring: Enable the Prometheus node exporter textfile collector.
>>   monitoring: Support extra options for the Prometheus node exporter.
>     ^
> Should be “services: prometheus-node-exporter: …”.
>
> Apart from that, on a quick look it LGTM.  Go for it!

Great, I've pushed as 92f7c11af26580a7e6543efa94531652f187923a.

Thanks,

Chris