Message ID | 87zh31u1q0.fsf@cbaines.net |
---|---|
Headers | show |
Series | Prometheus node exporter service enhancements | expand |
Hi, Christopher Baines <mail@cbaines.net> skribis: > services: monitoring: Neaten up the Prometheus node exporter. > monitoring: Add user and group for the Prometheus node exporter. > services: monitoring: Use a log file for Prometheus node exporter. > doc: Remove redundant node exporter configuration from the example. > monitoring: Enable the Prometheus node exporter textfile collector. > monitoring: Support extra options for the Prometheus node exporter. ^ Should be “services: prometheus-node-exporter: …”. Apart from that, on a quick look it LGTM. Go for it! Thanks, Ludo’.
Ludovic Courtès <ludo@gnu.org> writes: > Hi, > > Christopher Baines <mail@cbaines.net> skribis: > >> services: monitoring: Neaten up the Prometheus node exporter. >> monitoring: Add user and group for the Prometheus node exporter. >> services: monitoring: Use a log file for Prometheus node exporter. >> doc: Remove redundant node exporter configuration from the example. >> monitoring: Enable the Prometheus node exporter textfile collector. >> monitoring: Support extra options for the Prometheus node exporter. > ^ > Should be “services: prometheus-node-exporter: …”. > > Apart from that, on a quick look it LGTM. Go for it! Great, I've pushed as 92f7c11af26580a7e6543efa94531652f187923a. Thanks, Chris