mbox series

[bug#58078,0/2] Fix two emacs packages with native compilation.

Message ID 87tu4vtoie.fsf@protonmail.com
Headers show
Series Fix two emacs packages with native compilation. | expand

Message

John Kehayias Sept. 25, 2022, 4:25 p.m. UTC 
Hi,

I noticed that emacs-pdf-tools was failing if trying to native compile at build with --with-input=emacs-minimal=emacs as noted in the recent native compilation news. The error was just an exit status of 255, but I diagnosed by running the given compilation command in emacs to find the problem. The culprit is missing the phase that adds the install directory to the native load path (where emacs will try to write the compiled files) for this package as it manually pulls in the emacs build phases. Simply adding this missing phase (new with native compilation) fixes the problem.

While I was at it, I checked for any other packages with a similar problem, with a quick search through emacs-xyz. I found only emacs-libgit and fixed it similarly. I may have missed others or in other modules, but pdf-tools was the only one so far from my emacs packages.

I checked that both packages build normally and with native compilation, and checked that those that depend on emacs-libgit built fine too.

Thanks!
John